ValveSoftware / steam-audio

Steam Audio
https://valvesoftware.github.io/steam-audio/
Apache License 2.0
2.27k stars 158 forks source link

[C API] phonon.h uses types from stdint.h but this header is not included #334

Closed ethindp closed 5 months ago

ethindp commented 6 months ago

System Information Please provide the following information about your system:

Issue Description The IPLHRTFSettings struct uses uint8_t, but the header does not include stdint.h, which leads to compilation errors. The only workaround is to pollute the global namespace by first including stdint.h and then phonon.h, in that order.

Steps To Reproduce Steps to reproduce the behavior:

  1. Just include phonon.h like you would any other header, without including stdint.h. A C/C++ compiler with permissive mode turned off will reject the code because uint8_t is undefined in phonon.h. (This scenario is common in C++ where one usually includes <cstdint>, not stdint.h.)

Crash Dump N/A

kisak-valve commented 6 months ago

Hello @ethindp, this should have already been addressed by #315.

ethindp commented 6 months ago

@kisak-valve Ah, I didn't know about that. No new release has been published fixing this so that's why I opened this issue.

Xottab-DUTY commented 5 months ago

https://github.com/ValveSoftware/steam-audio/releases/tag/v4.5.3 was published. This issue can be closed :)