search

ValveSoftware / steam-audio

Steam Audio
https://valvesoftware.github.io/steam-audio/
Apache License 2.0
2.2k stars 152 forks source link

Don't link delayimp on UWP because it doesn't exist there #349

Open Ravbug opened 2 months ago

Ravbug commented 2 months ago

delayimp.lib does not exist on UWP, but SteamAudio always tries to link it on Windows platforms. This PR prevents SteamAudio from linking delayimp.lib on UWP. SteamAudio still works on UWP without it.

lakulish commented 1 month ago

Did you need to make any other changes in order to build for UWP? I tried building your branch for UWP and it didn't seem to work.

Ravbug commented 1 month ago

What error did you get when trying to build UWP?

lakulish commented 1 month ago

I got the following error:

error MSB8024: Using static version of the C++ runtime library is not supported.

Which can be fixed by removing the /MT flag set in the root CMakeLists.txt, but it would also require all dependencies to be built without static linking to the CRT, which would involve changing the dependency building scripts as well.

Ravbug commented 1 month ago

Which can be fixed by removing the /MT flag set in the root CMakeLists.txt

I checked my copy and found that I also did that. My project builds SteamAudio's dependencies as part of the cmake build tree. Maybe an option could be added to disable adding the /MT flag?