search

ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.22k stars 174 forks source link

[GoldSource] fpx_max, cl_showfps and net_graph issue #1706

Closed LevShisterov closed 11 years ago

LevShisterov commented 11 years ago

On current build if you set fps_max 100 net_graph show that you have 101 fps and cl_showfps 1 shows that you have 100 fps. if you set fps_max 100.5 net_graph show that you have 101.5 fps and cl_showfps 1 shows that you have 101 fps.

This was a recent change that leads to that behavior. Please change it back. We are really get accustomed to previous behavior. I.e. real fps should be always equal or below fps_max. If you wish to show it nicer when real fps is 99.99 (for fps_max 100) then use cell function to round to bigger integer.

Thanks.

r3n4m3 commented 11 years ago

I experienced a sense of deja vu because I saw it before, here https://github.com/ValveSoftware/steam-for-linux/issues/1628 (f4k3 comment)

LevShisterov commented 11 years ago

Yes, thanks, it's the same. Pity it is closed.

johndrinkwater commented 11 years ago

You’re right, this is a duplicate thats been explained as not a bug…

LevShisterov commented 11 years ago

But it is definitely poor behavior. Let we see, what developers will say about it. I my opinion, if code isn't allowing to be changed back, and if fps are going up for no more then 1, then better use (fps_max - 1) value in the code and all will be happy.

LevShisterov commented 11 years ago

Hey, don't close it, please. "The change was to allow up to 100.9 FPS in the case of 100 fps_max" this was in explanation. Can you tell why this change was done? I didn't seen explanation of this.

johndrinkwater commented 11 years ago

Please comment on the other bug as I am not a goldsrc dev, though I don’t understand why users couldn’t just enter fps_max 99 if they dislike seeing 101…

LevShisterov commented 11 years ago

I am just afraid they don't read closed issues, so I created new. Not sure how to be now...

LaurentiuAndrei commented 11 years ago

Oh come on! Since the fps is no longer limited by a cvar (like developer) now it's just ruined, because some servers automatically force my fps_max on 101 and it's a different movement...