ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.21k stars 174 forks source link

Requesting key... never completes for CD key #212

Closed jvarho closed 2 years ago

jvarho commented 11 years ago

I'm trying to get the CD key link for a non-Linux game I own (Crusader Kings II), so I can use it to sign up on their forums. The request never completes, it just says "Requesting key..." and copying to clipboard does nothing.

1) Open the game in library. 2) Click the CD key link on the right hand side. 3) A new window pops up but the request never completes.

System info:

Processor Information: Vendor: AuthenticAMD Speed: 2800 Mhz 4 logical processors 4 physical processors HyperThreading: Unsupported FCMOV: Supported SSE2: Supported SSE3: Supported SSSE3: Supported SSE4a: Supported SSE41: Unsupported SSE42: Unsupported

Network Information: Network Speed:

Operating System Version: Ubuntu 12.10 (64 bit) Kernel Name: Linux Kernel Version: 3.5.0-21-generic X Server vendor: The X.Org Foundation X Server release: 11300000

Video Card: Driver: X.Org Gallium 0.4 on AMD RV770

Driver Version:  2.1 Mesa 9.0
Desktop Color Depth: 24 bits per pixel
Monitor Refresh Rate: 60 Hz
VendorID:  0x1002
DeviceID:  0x9442
Number of Monitors:  1
Number of Logical Video Cards:  1
Primary Display Resolution:  1920 x 1080
Desktop Resolution: 1920 x 1080
Primary Display Size: 20.08" x 11.30"  (23.03" diag)
                                        51.0cm x 28.7cm  (58.5cm diag)
Primary VRAM Not Detected

Sound card: Audio device: Nvidia MCP77/78 HDMI

Memory: RAM: 3954 Mb

Miscellaneous: UI Language: English LANG: en_US.UTF-8 Microphone: Not set Total Hard Disk Space Available: 24605 Mb Largest Free Hard Disk Block: 16279 Mb

Installed software:

Recent Failure Reports: Fri Dec 21 11:53:12 2012 GMT: file ''/tmp/dumps/assert_20121221135304_1.dmp'', upload yes: ''CrashID=bp-20540da8-691f-4d9d-be7c-a727e2121221''

cverstege commented 3 years ago

In Windows the Mac key is not retrievable as well. Steam is stuck requesting the key. The key window opens, but requesting the key won't finish. On linux the key windows won't even open and the error message to try again in a few minutes pops up immediatly.

On Windows the Mac DLCs won't even install/are not visible at all. So on Windows the Steam client only installs the Windows Key DLC (33361) and doesn't even list the Mac Key DLC (33362) as available.

So this is acutally not a bug when requesting the CD key, but rather a SteamPlay bug, where Steam on Linux makes the Mac Only DLC available as well, even though we do only want the Windows version to be installed and to be used with Proton!

Edit: spelling

vaslabs commented 3 years ago

+1 It looks like a steam play issue, even if I do

WINEPREFIX=~/.steam/steam/steamapps/compatdata/33230/ ~/.steam/steam/steamapps/common/Proton\ 5.13/dist/bin/wine AssassinsCreedIIGame.exe

it still goes for the key

Cheaterman commented 3 years ago

Valve, please fix.

For what it's worth, I tried all the workarounds and the binary hacking I could on the appinfo.vdf, also using SteamEdit (which does not list the "Brotherhood Mac Key" DLC, or other DLCs in general?) to fix the checksum after making manual changes. I tried to set showcdkeyonlaunch to 0 (first only on the Mac DLC, then on both), no success. I tried the legacykeyregistrylocation thing, no effect. I tried adding is_hidden to steam_edit dict, no success - file becomes unable to load in SteamEdit so I'm sure enough it wouldn't load in proper Steam - I suspect the size of the dict is stored somewhere in the header given the diffs I observed. I tried manually requesting the key - and I've got my key, but I tried adding it to registry.vdf, no success.

I want to play this game please.

Valve, please fix.

cverstege commented 3 years ago

@Cheaterman check out https://github.com/ValveSoftware/Proton/issues/190#issuecomment-734984986 SteamEdit does list DLCs, you need to toggle them in the bar at the top right. There is a filter where you can turn on/off games, dlcs, movies, software etc. SteamEdit DLCs Do you see the green switch at the list on the top right. That's for DLCs. I did turn everything else off, that's why the buttons are grey. Then find the Brotherhood Mac DLC and set it to hidden for the game to launch. You also need to disable the steam overlay. Otherwise steam will crash when launching the game. The game will be running fine, but steam won't track your playtime. See #7494.

Cheaterman commented 3 years ago

Hahaha, thanks a lot @cverstege !!! I'm sorry to be that dumb, I didn't realize these icons were filters, I thought they were attibutes of whatever we had selected! I assure you that I tried hard, hahaha.

I confirm the key shows successfully when the file is edited through SteamEdit, stuff is installing right now, I'll confirm if I need to disable Steam overlay in an edit.

Thanks a lot again, sorry it wasn't clear for me :-)

EDIT: I'm using Proton 5.13 and it seems the overlay crashes by itself, but doesn't take the game with it - Steam does seem to exit though. The Ubi overlay on the other hand is a trap, it freezes the game instantly, and displays a pop-up in the top right corner if I don't - I can probably disable it entirely.

EDIT2: I confirm the game works perfectly, except it stutters occasionally, I strongly suspect it's when compiling the shaders, there's no shader pre-caching for this game it seems, and fossilize isn't doing its thing. Minor annoyance really - the game is very much playable here. Thanks again @cverstege

Cheaterman commented 3 years ago

With the brand new update to Proton, the game crashes to desktop again. Probably not the right place for it, I'll look for the appropriate issue.

EDIT: https://github.com/ValveSoftware/Proton/issues/4458

vaslabs commented 3 years ago

I tried the steam edit suggestion and it worked !!! Thanks @cverstege . To run steam edit easily on Linux: Create a new wine prefix e.g ~/.steamedit with winetricks. Create a symbolic link in drive_c/Program Files (x86)/Steam that points to ~/.steam/steam

cd ~/.steamedit/drive_c/Program\ Files\ \(x86\)
ln ~/.steam/steam -s Steam

, install dotnet461 with winetricks ( I think dotnet 5 also works)

WINEPREFIX=~/.steamedit winetricks

Then run WINEPREFIX=~/.steamedit wine SteamEdit.exe

mendiromania commented 3 years ago

please @kisak-valve fix this I do not have windows to check the cd keys and running a 3rd party app is just meh, I'll do it this time but it's meh.

Cheaterman commented 3 years ago

I don't have Windows either but TBF the SteamEdit thing is good enough. Besides it's probably out of Valve's control so please be nice to Kisak 😅

mendiromania commented 3 years ago

kisak is cool but showing cd keys for a game i paid for is totally under valve's control edit: steamedit doesn't actually show cd keys so i had to install steam inside wine to get the cd key

Cheaterman commented 3 years ago

Perhaps you are right, yes. Re-reading the context, it does seem to be the consensus, but with a functioning workaround I can see how this is low priority on their TODO list 🙂

mendiromania commented 3 years ago

It doesn't sound that hard to implement (the feature works for linux games, I guess there's a check wether it's a platform game or not).

edit: just realised this issue was posted on Dec 21, 2012! so it's not even on their to do list

mendiromania commented 3 years ago

the option now appers under manage > cd keys, but it fails to retrieve the cd keys with message: Failed to request product key from Steam, please try again in a few minutes

but hey, it's progress, hats off kisak

rileyrg commented 3 years ago

AC Odyssey there is no cdkeys undermanage.Where is it? Im tired f fighting with uplay.

smintman commented 2 years ago

Please please Valve can you resolve this we shouldn't need to hacking the files to get this to work, just correct the client incorrectly trying to request the Mac DLC!?!?

ell1e commented 2 years ago

This still seems to be broken, around 9 years later. Slightly baffling. What's the hold-up?

jakob11git commented 2 years ago

Please Valve I want to get my CD key for the game I bought. Doesn't matter if it's a Windows game and I'm on Mac.

PolarBass0511 commented 2 years ago

Hello, I was told by "Charles" to post in this specific thread. This is in regards to my current ticket in with Steam Support (Ticket: HT-5XTF-6F3Y-DWVW). I run PoP!_OS on an AMD/ATI machine, and reference ProtonDB with every game I play. Although I have not had a problem with Assassin's Creed I, II, Odyssey, or Origins, AC Brotherhood and Revelations refuse to let me play. I will click play, and then receive an error that Steam failed to retrieve or request an activation key. Using the Manage > CD Keys option pulls the same error. Either way, I can go no further in attempting to play the game(s) until this is resolved. I even downloaded the Ubisoft Connect client, and can successfully run it through Steam client via Proton 6.3-8, but this game does not show, and the key I received from "Charles" today was read as not valid. Many thanks for any help you can provide, as I would love to continue the AC story, support Steam, and not feel like I was cheated out of money that could have been better used as a student loan payment.

cverstege commented 2 years ago

@PolarBass0511 you can try and run steam steam://cdkeys/33361 in the terminal to get the AC II key and activate it in uplay afterwards.

smintman commented 2 years ago

@PolarBass0511 I wrote a script to get AC 2 and Brotherhood working. I've not had an issue with getting CD key for revelations so not added it but maybe could help you with brotherhood

https://github.com/smintman/assfix

begin-theadventure commented 2 years ago

~~https://github.com/begin-theadventure/acfix I created another way to apply the fix for Assassin's Creed, which I think is better because you can add it to multiple ACs at once - practically unlike with .vdf - theoretically well unless you wanna share your entire library... +I added fixes for Unity and Brotherhood Standard Edition.~~ Not needed anymore.

tijder commented 2 years ago

It looks like this bug is finally solved! Today I could start AC:II and AC:Brotherhood without any problems. Steam even showed the cd key! :tada:

KnightOfCups commented 2 years ago

Well there is definitely a change, this time I successfully launched ACII whereas I was stuck before with the CD key request. I made it in two steps:

smintman commented 2 years ago

I managed to load Assassins creed 2 deluxe and Brotherhood without issue too! (well ubisoft connect crashes after update, but second try works fine) Hopefully this is resolved now.... only took 10 years!!!

Can others give it a go and check?

cverstege commented 2 years ago

Seems to be fixed in the current Steam Beta (2nd April 2022). The normal Client still does not work. (ACII and AC Brotherhood)

begin-theadventure commented 2 years ago

It looks like this bug is finally solved! Today I could start AC:II and AC:Brotherhood without any problems. Steam even showed the cd key! tada

I forgot to reply after this comment but it does indeed work now for AC: II, Brotherhood & Unity.

peldax commented 2 years ago

AC2 is still not working for me. I am getting following prompt: Screenshot_2022-04-26_11-59-12 I already played the game on windows few years ago, so its kinda weird that my key is not attached to my account already.

smintman commented 2 years ago

Replying to https://github.com/ValveSoftware/steam-for-linux/issues/212#issuecomment-1111127247

Are you using the beta steam client?

EyeOfMidas commented 2 years ago

I just enabled the Steam Beta Client, restarted Steam and played Assassin's Creed II for 10 minutes. It works perfectly. Can't wait for this to be in the main release and we can finally close this 10-year-old issue. 👍

peldax commented 2 years ago

Replying to #212 (comment)

Are you using the beta steam client?

I just updated to Steam Beta and its working. Thanks!

kisak-valve commented 2 years ago

Closing as fixed in the 2022-05-12 Steam client update (uncredited).