ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.24k stars 175 forks source link

[Steam client] full-screen videos play in bottom left of desktop and is confined to size of Steam client window #3699

Closed ghost closed 6 years ago

ghost commented 9 years ago

If you have the Steam client in a smaller-than-fullscreen window (as most users do) then hit the full-screen button on a game store page video, the full-screen video will match the size of the Steam client window, except it will appear in the lower left of the screen. The rest of the screen will be black, and the buttons will be in the location they should have been. This means that to unmaximize the video, you have to hover your mouse cursor in some small spot in the bottom right corner. You will see the unmaximize button light up as it should on the left side once you hover in the right spot and can then click to unmaximize.

If you stretch out the Steam client window to make it "tall", the full-screen video will actually be stretched "tall" as well and looks pretty funny! :D

If you full-screen the Steam client window, then it will play on almost the entire screen as it should, but it's still somewhat offset to the left and not entirely correct as you'll see when you try to hover your cursor over the unmaximize button.

Probably unrelated output at around the same time: Installing breakpad exception handler for appid(steam)/version(1422054110) [0201/104714:ERROR:renderer_main.cc(227)] Running without renderer sandbox

Distro is Linux Mint 17.1.

Before full-screened Before full-screened

After full-screened After full-screened

Processor Information:
    Vendor:  GenuineIntel
    CPU Family:  0x6
    CPU Model:  0x3a
    CPU Stepping:  0x9
    CPU Type:  0x0
    Speed:  3500 Mhz
    8 logical processors
    4 physical processors
    HyperThreading:  Supported
    FCMOV:  Supported
    SSE2:  Supported
    SSE3:  Supported
    SSSE3:  Supported
    SSE4a:  Unsupported
    SSE41:  Supported
    SSE42:  Supported

Network Information:
    Network Speed:  

Operating System Version:
    Linux Mint 17.1 Rebecca (64 bit)
    Kernel Name:  Linux
    Kernel Version:  3.13.0-37-generic
    X Server Vendor:  The X.Org Foundation
    X Server Release:  11501000
    X Window Manager:  Mutter (Muffin)
    Steam Runtime Version:  steam-runtime-release_2015-01-06

Video Card:
    Driver:  NVIDIA Corporation GeForce GTX 680/PCIe/SSE2

    Driver Version:  4.5.0 NVIDIA 346.35
    OpenGL Version: 4.5
    Desktop Color Depth: 24 bits per pixel
    Monitor Refresh Rate: 59 Hz
    VendorID:  0x10de
    DeviceID:  0x1180
    Number of Monitors:  1
    Number of Logical Video Cards:  1
    Primary Display Resolution:  3840 x 2160
    Desktop Resolution: 3840 x 2160
    Primary Display Size: 24.45" x 13.43"  (27.87" diag)
                                            62.1cm x 34.1cm  (70.8cm diag)
    Primary Bus: PCI Express 16x
    Primary VRAM: 4096 MB
    Supported MSAA Modes:  2x 4x 8x 16x 

Sound card:
    Audio device: Realtek ALC892

Memory:
    RAM:  15993 Mb

Miscellaneous:
    UI Language:  English
    LANG:  en_US.UTF-8
    Microphone:  Not set
    Total Hard Disk Space Available:  3560196 Mb
    Largest Free Hard Disk Block:  2362054 Mb

Installed software:

Recent Failure Reports:
ViBE-HU commented 8 years ago

same here. and the volume bar is in the middle everytime.

OS: Ubuntu 14.04 x64 DE: Unity GPU: Intel HD3000

tr37ion commented 8 years ago

It'll be interesting if this will be fixed 2016 ;)

mtcs commented 8 years ago

+1 screenshot from 2016-01-15 14-50-40

OS: Arch Linux WM: Gnome GPU: Nvidia GTX 640M

LiraNuna commented 8 years ago

Still no acknowledge from Valve? This is still happening

Plagman commented 8 years ago

We can reproduce this internally but haven't been able to track down the issue within the CEF code yet. I will upate this bug when we have news.

antonkurkin commented 8 years ago

IIRC it started to happen just after video fullscreen mode was changed to cover actual full screen. Before that video fullscreen was only covering an area inside of the steam client (web part, excluding its borders and header).

dmutters commented 8 years ago

Thank-you for the response, Plagman!

I'm wondering if the code to make it full-window has simply propagated to the code to make it full-screen. This might be a regression resulting from the implementation of Big Picture Mode, which would explain why the "full screen" video is only as large as the window it started with. I've noticed that the "full screen" video will always be the size of the viewable area of the original window. I.e. resizing/maximizing the Steam window before attempting to go full-screen makes the resulting video bigger--albeit still not properly full-screen. In Big Picture Mode, the viewable area of the Steam window is already full screen, so it's not an issue.

A quick workaround might be to include a few lines of code to maximize the window upon being commanded to go full screen, then making it display full screen, then resizing the window, afterward. It would still be ugly, and the buttons would still be slightly offset, but it would be much better than the present behavior, until something more permanent can be introduced.

Thanks for your work, Valve. :-)

tr37ion commented 8 years ago

Btw. did someone test it with x/Wayland (Weston)?

antonkurkin commented 8 years ago

Guys, is it my system or was this problem fixed in one of the latest beta client updates? Didn't check it for week or two, and now it just works.

Fincer commented 8 years ago

Nope, I still have the issue. Just checked and updated the client.

Steam client application: Steam API: v017 Built: Mar 10 2016, at 10:44:34 Steam package versions: 1457636973

rkfg commented 8 years ago

Hmmm, it seems you're right! It works for me as well on Steam Beta. The only issue is that the fullscreen window pops up under the Steam itself but that's a configuration issue with Awesome WM. I'll sort it out myself. I don't know how to copy the "About Steam" info, mine is built at Mar 18 2016.

ViBE-HU commented 8 years ago

the topic is still open so it's still an issue. and yes the whole video player is buggy on my 14.04 too.

antonkurkin commented 8 years ago

Fincer, is it beta? I have Steam package versions: 1458336029 (same as rkfg I believe) ViBENo1, maybe it wasn't registered yet or fixed unintentionally?

WiseTrem commented 8 years ago

Looks fixed on my Gentoo with DWM.

Fincer commented 8 years ago

@antonkurkin

Right, enabled Steam Beta and updated the client. I have build 1458336029 (Mar 18 2016) now and the issue seems to be fixed. I tested a couple of trailer videos and haven't a single issue with them anymore.

dmutters commented 8 years ago

I just enabled Steam Beta, and now it works! Way to go, Valve!

Let's keep an eye out for regressions, just in case...

boombatower commented 8 years ago

Can confirm seems to work for me in beta client as well! Thanks Valve!

ViBE-HU commented 8 years ago

@antonkurkin somehow the update bit delayed for me. all of you right. it's finally fixed. i can't believe it.

rkingsbury commented 8 years ago

Fixed for me on Linux Mint 17.3 (Ubuntu 14.04) with Cinnamon. Thanks Valve!

ghost commented 8 years ago

Thanks so much for fixing this!!! :wolf:

antonkurkin commented 8 years ago

@Plagman could you reopen this bug please? There was a regression and now fullscreen videos are playing just like it was before fix. I have steam client version 1461972496, can someone else reproduce it? Steam update also fixed full screen in big picture mode (before last update, i believe, it was covering only a part of the monitor). Probably it's related?

rkfg commented 8 years ago

Damn, you're right. It's broken again...

WiseTrem commented 8 years ago

True, have the same issue again.

dmutters commented 8 years ago

I can confirm that the problem has re-emerged for me since installing the April 29th update. (I'm in the Steam Beta program.)

Help > About Steam (transcribed by hand): Steam client application Built: Apr 29 2016, at 22:27:58 Steam API: v017 Steam package versions: 1461972496

ghost commented 8 years ago

Emailed Plagman to re-open this ticket. I can confirm this issue in the stable Steam Linux client, and others have confirmed it in the beta client.

dmutters commented 8 years ago

I just did a steam client update, today (beta enabled), and it's still a problem. Screenshot attached. Insurgency's store page.

screenshot from 2016-06-05 11 03 49

antonkurkin commented 8 years ago

It's more than a month since regression already and I'm not sure how it should be done. should we file another bug to reopen this one?

dmutters commented 8 years ago

I think that re-opening this one is best, for now. It took a few months to get attention from Valve, when the bug was opened. If there's still no attention after 6 months, we can open a new bug and reference this page in that one.

Tele42 commented 8 years ago

It probably should be noted that libcef (embedded chromium) should be providing this functionality, and the fix and subsequent regression is most likely due to upstream changes.

Plagman commented 8 years ago

Thanks, reopening.

anassahmed commented 8 years ago

I confirm having the issue on Fedora 24 (GNOME 3.20 under X.org) - Installed the client from Negativo17 repository.

My Steam Version (Beta Program):

Built: Jun 1, 2016 at 21:41:31
Steam API: v017
Steam Package Versions: 1464823435

Under Wayland, it's way worse! At least under X.org, I can see the player toolbar (Play/Pause buttons) but under Wayland, the whole player is shifted to the bottom with the same issue of empty top screen.

dmutters commented 8 years ago

I just installed Linux Mint 18 Cinnamon, which is based on Ubuntu 16.04 LTS, and can confirm that the problem still exists.

Tested on this page, in Steam (right-click, Copy Page URL): http://store.steampowered.com/app/222880/

Computer Information: Manufacturer: Unknown Model: Unknown Form Factor: Desktop No Touch Input Detected

Processor Information: CPU Vendor: GenuineIntel CPU Family: 0x6 CPU Model: 0x2a CPU Stepping: 0x7 CPU Type: 0x0 Speed: 3800 Mhz 8 logical processors 4 physical processors HyperThreading: Supported FCMOV: Supported SSE2: Supported SSE3: Supported SSSE3: Supported SSE4a: Unsupported SSE41: Supported SSE42: Supported AES: Supported AVX: Supported CMPXCHG16B: Supported LAHF/SAHF: Supported PrefetchW: Unsupported

Network Information: Network Speed:

Operating System Version: Linux Mint 18 Sarah (64 bit) Kernel Name: Linux Kernel Version: 4.4.0-21-generic X Server Vendor: The X.Org Foundation X Server Release: 11803000 X Window Manager: Mutter (Muffin) Steam Runtime Version: steam-runtime-beta-release_2016-06-15

Video Card: Driver: NVIDIA Corporation GeForce GTX 980/PCIe/SSE2

Driver Version:  4.5.0 NVIDIA 361.42
OpenGL Version: 4.5
Desktop Color Depth: 24 bits per pixel
Monitor Refresh Rate: 59 Hz
VendorID:  0x10de
DeviceID:  0x13c0
Revision Not Detected
Number of Monitors:  1
Number of Logical Video Cards:  1
Primary Display Resolution:  1680 x 1050
Desktop Resolution: 1680 x 1050
Primary Display Size: 18.66" x 11.65"  (21.97" diag)
                                        47.4cm x 29.6cm  (55.8cm diag)
Primary Bus: PCI Express 16x
Primary VRAM: 4096 MB
Supported MSAA Modes:  2x 4x 8x 16x 

Sound card: Audio device: Realtek ALC898

Memory: RAM: 15928 Mb

Miscellaneous: UI Language: English LANG: en_US.UTF-8 Microphone: Not set Total Hard Disk Space Available: 2797332 Mb Largest Free Hard Disk Block: 2180001 Mb VR Headset: None detected

Plagman commented 7 years ago

The latest Beta cycle did a major revision to the web component of Steam, thought to have been the cause of this issue in the past. Can anyone reproduce this issue on the current Beta?

Tele42 commented 7 years ago

I can confirm the quirk behavior is present with the 2016-11-23 steam beta client on Gentoo Linux no steam runtime.

Addition: So, it looks like this occurs on my primary desktop which is 2x 1920x1080 w/ nvidia 370.28 but not my low-perf laptop which is also Gentoo no steam runtime, 1366x768 w/ mesa 13.0.1 r600 (evergreen generation). The desktop is using Cinnamon 3.0 (muffin), and the laptop is using MATE 1.12.1.

ghost commented 7 years ago

The revision to the Steam website was only to the front page it seems. I can't find any videos which will play from the front page. The videos for the games in the individual game store pages still have this bug.

anassahmed commented 7 years ago

Steam (as of Nov 30, 2016 version) which brings some new updates regarding DRM-protected videos (Widevine), still doesn't solve this bug under GNOME 3.22.2 (Mutter 3.22.2 under Wayland) with Fedora 25 (Secondary Screen without Top-bar).

Attached a photo of the current issue, where the video is almost half the screen in height with a black strip above (in screenshot, in reality it shows a flickering image), and there's small black strip on the right reduces the width of the player (but when you hover on the player buttons (e.g. Full screen button), they don't get active without hovering over their hypothetical position in the black right strip).

steamfullscreenvideo

nE0sIghT commented 7 years ago

Still issue in 2017

Leopard1907 commented 7 years ago

It's a problem.It happens every video.Also client goes flashing at this state ekran goruntusu - 2017-02-05 01-18-32

RicardoEPRodrigues commented 7 years ago

This issue is a year old and is still not fixed. Is there a fix being worked on?

juleskers commented 7 years ago

Same problem here on OpenSuse Tumbleweed (64 bit), running on an AMD R9 380.

Steam client: version 1489442219 amdgpu driver: libdrm_amdgpu1, version 2.4.75-1.1 mesa: 17.0.1-157.1 monitor resolution: 3440x1440 (21:9)

qalshidi commented 7 years ago

Same problem here Manjaro rolling latest using native runtime library. $ uname -a Linux Centaur 4.10.4-1-MANJARO #1 SMP PREEMPT Sun Mar 19 08:51:42 UTC 2017 x86_64 GNU/Linux

dmutters commented 7 years ago

Fixed! As of the latest update, fullscreen is working properly.

Steam client built: Mar 30 2017, at 15:23:05 Steam API: v017 Steam Package Version: 1490914880

Computer Information: Manufacturer: To Be Filled By O.E.M. Model: To Be Filled By O.E.M. Form Factor: Desktop No Touch Input Detected

Processor Information: CPU Vendor: GenuineIntel CPU Brand: Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz CPU Family: 0x6 CPU Model: 0x2a CPU Stepping: 0x7 CPU Type: 0x0 Speed: 3400 Mhz 8 logical processors 4 physical processors HyperThreading: Supported FCMOV: Supported SSE2: Supported SSE3: Supported SSSE3: Supported SSE4a: Unsupported SSE41: Supported SSE42: Supported AES: Supported AVX: Supported CMPXCHG16B: Supported LAHF/SAHF: Supported PrefetchW: Supported

Network Information: Network Speed:

Operating System Version: Windows 10 (64 bit) NTFS: Supported Crypto Provider Codes: Supported 311 0x0 0x0 0x0

Video Card: Driver: Intel(R) HD Graphics

DirectX Driver Name:  nvd3dum.dll
Driver Version:  9.17.10.4459
DirectX Driver Version:  21.21.13.7892
Driver Date: 19 May 2016
OpenGL Version: 4.5
Desktop Color Depth: 32 bits per pixel
Monitor Refresh Rate: 143 Hz
DirectX Card: NVIDIA GeForce GTX 980
VendorID:  0x10de
DeviceID:  0x13c0
Revision:  0xa1
Number of Monitors:  1
Number of Logical Video Cards:  1
No SLI or Crossfire Detected
Primary Display Resolution:  2560 x 1440
Desktop Resolution: 2560 x 1440
Primary Display Size: 23.50" x 13.23"  (26.97" diag)
                                        59.7cm x 33.6cm  (68.5cm diag)
Primary Bus: PCI Express 16x
Primary VRAM: 4095 MB
Supported MSAA Modes:  2x 4x 8x 

Sound card: Audio device: Speakers (High Definition Audio

Memory: RAM: 16265 Mb

Miscellaneous: UI Language: English Microphone: Not set Steam Controller Cable and Base: Not set Media Type: DVD Total Hard Disk Space Available: 5722492 Mb Largest Free Hard Disk Block: 2218834 Mb OS Install Date: Dec 31 1969 Game Controller: None detected VR Headset: None detected

dmutters commented 7 years ago

I just installed another update, and it's broken, again.

Built: Mar 30 2017, 22:20:57 Steam API: v017 Steam package version: 1490914880 (All of this appears to be the same, except for the build time.)

rkfg commented 7 years ago

It's like they noticed this is fixed and broke it again without even changing the build number. Just because. Welp, two years isn't that big of a time, remember the 12309 bug?

dmutters commented 7 years ago

Well, hopefully having very specific data on which versions fix/regress the issue will help get it resolved, for good. At this point, I think all we can do is let them know when things work/don't work, what versions we're using at the time, and any other relevant information we can think of. When the Steam dev team is ready to really tackle the issue, they'll at least have some good data to work with.

You mean that I/O wait bug in the Linux kernel? Yeah, that one drives me nuts, sometimes. In certain kernel versions (or when the stars align "just so"?), you can't copy a file and do other stuff at the same time, no matter how many CPU cores or hard drives you have. It seems mostly fixed, now, but they're still actively working the problem on Bugzilla. Here's hoping this Steam bug doesn't take 9+ years to resolve...

Leopard1907 commented 7 years ago

It looks like it is partially fixed ; however i think that problems are a little bit related to uploaded videos width,length etc. Looks like Steam client can't upscale or downscale them correctly.

ekran goruntusu - 2017-04-09 03-34-29 ekran goruntusu - 2017-04-09 03-37-13

This first two screenshots are from game Inner Chains page.

It looks perfectly normal and it also looks same on web browsers. I tried with Chrome.

However ; at this page something weird happens. This game is CrossCode.

ekran goruntusu - 2017-04-09 03-37-58

Same video looks normal with Chrome.

ekran goruntusu - 2017-04-09 03-50-51

Mad Max-Steam Client

ekran goruntusu - 2017-04-09 03-38-56

Mad Max-Chrome

ekran goruntusu - 2017-04-09 03-53-18

@Plagman

Info:

ekran goruntusu - 2017-04-09 03-57-02

Linux Mint 18.1-Mesa 17.0.3 drivers provided via Padoka Stable Ppa

dmutters commented 7 years ago

If it's an upscaling issue, and not all videos are uploaded at the same quality, that would explain some of the intermittence we're seeing. To do a proper test, we probably need to check with a number of different videos on different games, from different publishers.

codetorex commented 7 years ago

I have this issue with arch linux, cinnamon desktop and amd open source drivers too. In my case different sizes are happening because of size of steam window. Don't know if it is same for you guys too. So renderer viewport of internal browser actually doesn't becomes fullscreen but still uses same size of client window. I think it might be a bug related to viewport resizing code not executed on fullscreen mode properly and a fix could be changing browser renderer viewport size to fullscreen during fullscreen event or just initialize and keep it as fullscreen size always. Just some guesses might help, don't know how it works internally :)

M-Reimer commented 7 years ago

Same problem here. Nvidia proprietary driver, Gnome desktop and Arch Linux. Any chance to see a fix in the foreseeable future?

RicardoEPRodrigues commented 7 years ago

Fun fact, I was scrolling through the new Nvidia 381.22 driver's change log and noticed this:

Fixed a bug that caused applications to crash in some situations when calling glXMakeCurrent while OpenGL threaded optimizations were enabled. This frequently occurred when Steam was attempting to make a video appear full-screen. http://news.softpedia.com/news/nvidia-381-22-video-driver-supports-newer-linux-kernels-more-vulkan-extensions-515570.shtml

Could someone install this new driver and test this out?