search

ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.19k stars 173 forks source link

Screenshots Break After Use #4928

Closed Spirrwell closed 6 years ago

Spirrwell commented 7 years ago

Your system information

Please describe your issue in as much detail as possible:

Describe what you expected should happen and what did happen. Please link any large code pastes as a Github Gist

While running games I would expect that pressing the screenshot button (F12) would result in a screenshot being taken which would then later prompt me to upload them to the Steam community.

However, when I run a game it seems I can only take 2-3 screenshots before it stops working. The games will stutter like I'm taking a screenshot, but no notification appears, and no screenshot is taken. The first 2-3 appear in my respective screenshot folders, the others do not.

I've tried a few random games and have had the same results, such as Saints Row the Third, some Source based game, and Duke3D Megaton Edition.

I opted into the Steam beta (the version I'm using now) with the same result.

I should also note that in my /tmp/dumps folder I seem to get some assert dumps.

If you need any additional information such as information from Steam if ran from the terminal, please let me know.

Steps for reproducing this issue:

  1. Open a game.
  2. Take some screenshots.
  3. Screenshots no longer work.
kisak-valve commented 7 years ago

I have seen similar behavior on my Fedora test box. The number of taken screenshots varied.

Spirrwell commented 7 years ago

Interesting, it seems to happen mostly every 2 screenshots. Also I noticed you added the "overlay" label. To clarify myself, the overlay itself still seems to work even after this happens.

ghost commented 7 years ago

For me screenshots sometimes don't work at all.

There was also another bug which crashes Steam if one tries to change window geometry of the screenshot uploader window while uploading screenshots (window that appears after game exists if screenshots are taken). Might be related. Will try to reproduce later if this issue allows me.

Spirrwell commented 7 years ago

Yeah I also tested with that new Serious Sam Fusion game and screenshots seemed to not work at all, but I thought it was maybe related to Vulkan or something. Though I tried switching the rendering API back to OpenGL and got the same resul.

ghost commented 7 years ago

My issue is fixed now. For the record, before I could consistently crash Steam by changing geometry during uploads on Ubuntu. Changing focus was ok and it only happened during the uploads. test

Regarding this issue, taking 3 screenshots on stable client worked. Beta client (with default skin) didn't work at all.

Spirrwell commented 7 years ago

Well the issue with the screenshots not working either at all or after taking a few still stands. If there's another issue like the window scaling crash, it should probably be opened up in a new issue. However you said this was fixed, so I guess it's not needed.

It's probably easier for them to track individual issues though.

ghost commented 7 years ago

@Spirrwell All true, and of course if I was able to reproduce my problem I would have opened new issue.

Like I said, it might be related. Geometry bug that crashes Steam on screenshot uploader got fixed and taking screenshots stopped working. There is another geometry bug visible in the gif above which is not fixed so that makes me even more suspicious issues are related.

Spirrwell commented 7 years ago

Eh, I think this issue is probably more related to the overlay. The Steam overlay is truly an amazing hack. I could be wrong but I believe the overlay sort of injects itself into the rendering pipeline.

That's probably why there's actual stutter when you take screenshots because it's probably capturing what's rendered instead of taking a literal capture of the screen.

I could be wrong though, but that sounds like how it would work.

ElectricTriangle commented 7 years ago

I can also confirm this issue. However in TF2's case, the game-specific screenshot key (F5) still works and adds them to the library per usual.

My system specs are in the gist below, please ask if you need any debug output or testing. https://gist.github.com/ElectricTriangle/96eab8d9837e338afa404351b656be9c

LiamDawe commented 7 years ago

Ah good, there's a bug open for this.

It's not game specific, or distribution specific. I've seen this across Antergos + GNOME & KDE. I'm also seeing it on Ubuntu across multiple desktops.

It's been messing up a few reviews I've tried writing recently, outside screenshot tools are problematic since they often minimize the game and mess things up. For me, it works for only one screenshot, no more than that.

Has there been any progress on it/can I do anything to help track it down?

facePlanted commented 7 years ago

Same here, problem still ongoing, only Valve's games are working (cs:go) other games would take the screenshot only first time, not at all or just freeze. Debian 8 jessie, gnome-shell, gtx980 nvidia drivers 375.66 Steam stable (not beta)

qptain-Nemo commented 7 years ago

Also have been experiencing this issue for a while now. Using non-beta client, Arch Linux 64 bit, Nvidia proprietary drivers and xfce.

vfjpl commented 7 years ago

Can anyone test if the same thing happen when you try to take a screenshot from a game that you didn't take any screenshot from?

qptain-Nemo commented 7 years ago

Yep, definitely. In some games even taking a single screenshot fails, but in some it stops after 3 as usual. Also pretty sure when the issue manifests the corresponding gameoverlayui process doesn't terminate with the game.

ramma commented 7 years ago

This has been happening for me in Dota 2. As mentioned above, the number of screenshots to trigger it initially is varied. Though I've noticed once it's happened, if the Steam client isn't restarted it always happens on the 2nd screenshot.

Unlike some above my entire overlay stops working after this happens until Steam is restarted.

System info

NoXPhasma commented 6 years ago

Most of the time I can't take any Screenshots anymore. And when it rarely works, it does it only once. When I hit F12 rapidly, the FPS will drop, so the Overlay is doing something.

This is in Steam stable and beta. My system: https://gist.github.com/NoXPhasma/547430b98390e86d7756fc6fdae82a96

headlesscyborg commented 6 years ago

I have the same problem, one or two screenshots and then nothing happens when I press F12. Howewer it always works in Valve games (CSGO, TF2) with no problems.

Steam: stable System info: https://gist.github.com/thedarkfighter413/2d1da49b2795821146b9ed129fa7911e

Faalagorn commented 6 years ago

The problem was recently brought on GamingOnLinux, so I finally realzied I'm not alone on the issue – it happens for me and wife for as long as I remember after switching to Linux last year (not sure if it appeared at the very beginning or broke after some update though), same as above, the screenshot tool only allows me to do a 2-3 screenshots before crashing so I stopped using it altogether and instead using gnome-screenshot for the screens – with that however, I can't upload them as screenshots to Steam obviously. It would be nice if that got fixed at some point, I'll be observing the issue.

emberquill commented 6 years ago

Starbound doesn't let me take screenshots at all. It just freezes every time and I have to kill it from the command line.

ProfanedBane commented 6 years ago

Can confirm this still is happening on Robocraft.

Every time a successful screenshot is taken "Installing breakpad exception handler for appid(steam)/version(1520641782)" is output to console, when screenshots start failing this is not output.

Brottweiler commented 6 years ago

I manage to take one (1) screenshot in Rocket League, I can hear the screenshot sound effect, and after that pressing the screenshot key does nothing.

headlesscyborg commented 6 years ago

I've noticed it always works in games ported by Feral Interactive (and Valve games). I made 200+ screenshots in Rise of the Tomb Raider, 250+ in Deus Ex Mankind Divided, ~50 in Dawn of War 3, ~100 in XCOM2 WOTC, 50+ in Life Is Strange etc. with no problems.

But from my experience here are some examples of games where it doesn't work at all, stops working after 1-2 screenshots or crashes the game:

cprn commented 6 years ago

Didn't Valve fix it in beta? There was a changelog entry about fixing screenshots on Linux for some engines (UE4 among others, I think).

On Mon, 30 Apr 2018, 14:00 thedarkfighter413, notifications@github.com wrote:

I've noticed it always works in games ported by Feral Interactive (and Valve games). I made 200+ screenshots in Rise of the Tomb Raider, 250+ in Deus Ex Mankind Divided, ~50 in Dawn of War 3, ~100 in XCOM2 WOTC, 50+ in Life Is Strange etc. with no problems.

But from my experience here are some examples of games where it doesn't work at all, stops working after 1-2 screenshots or crashes the game:

  • Divinity: Original Sin
  • Metro 2033 Redux
  • Metro Last Light Redux
  • Pillars of Eternity
  • The Talos Principle

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ValveSoftware/steam-for-linux/issues/4928#issuecomment-385378263, or mute the thread https://github.com/notifications/unsubscribe-auth/AF2T5ClAeQCYWiQ2qMG0174GPsElWOxgks5ttvzngaJpZM4M9Y5I .

ArekPiekarz commented 6 years ago

@cprn Unfortunately the issue still exists in the Steam beta. Making screenshots after a few tries either break or completely freeze the games. I tested it in:

My setup: Xubuntu 17.10 x64 Nvidia Geforce GTX 1050 Ti Nvidia proprietary drivers 396.18 Packages fully updated Steam build: Apr 30 2018, at 13:37:39

ghost commented 6 years ago

Issue is still present for me as well(cc @kisak-valve @Plagman ) , experiencing this in The Witcher 2. In my case it seems to break after first use.

Arch Linux OpenGL renderer string: AMD Radeon HD 7900 Series (TAHITI / DRM 3.23.0 / 4.16.7-1-ARCH, LLVM 6.0.0) OpenGL core profile version string: 4.5 (Core Profile) Mesa 18.0.3 Steam build: April 2 2018 at 15:23:55

kisak-valve commented 6 years ago

Has anyone seen this issue since the 2018-05-15 Steam beta client update? A potentially related overlay freeze was triaged in that update.

Brottweiler commented 6 years ago

@kisak-valve Oh! It seems to be fixed for me. I can now take multiple screenshots in Rocket League, whereas before I could only take 1.

ArekPiekarz commented 6 years ago

I can also confirm it is working properly now. Thanks for that!

Spirrwell commented 6 years ago

So far seems to be working well for me. I really hope this issue is finally dead. :D Thanks a lot!

kisak-valve commented 6 years ago

Thanks for retesting.

Closing as fixed at the same time #4933 was fixed.

BlizzieM commented 1 year ago

Issue seems to be back as of November 2022. Taking screenshot with F12 crashes the overlay and breaks controller support on games using steam's controller utility on the main version of steam. Using Arch linux as distro.

kisak-valve commented 1 year ago

Hello @BlizzieM, you're looking for #8871 instead of this issue report.