ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.21k stars 174 forks source link

Change of Proton Version - redownload of whole game #5761

Open kisak-valve opened 6 years ago

kisak-valve commented 6 years ago

Issue transferred from https://github.com/ValveSoftware/Proton/issues/1448. @nilleairbar posted on 2018-09-14T16:37:16:

Every game that I had downloaded via SteamPlay got deleted. Folder structure of the games are still intact but the Steam update deleted all other files of the games. Back to Windows I guess. No way in hell will I download hundreds of GB again just to get those removed again with the next update.

nilleairbar commented 6 years ago

To add to that since kisak transferred the issue because it directly relates to the client, no native Linux game got deleted. This issue only pertains to SteamPlay titles.

kisak-valve commented 6 years ago

Hello @nilleairbar, please copy your system information from steam (Steam -> Help -> System Information) and put it in a gist, then include a link to the gist in this issue report. Additionally, have you changed any settings in the Steam Play section of Steam's settings and what filesystem(s) do you use for your steam library?

nilleairbar commented 6 years ago

System Info gist is here. I didn't change anything in the Steam Play settings. Booted up Steam and wanted to start DQ 11 and got a notification telling me that I'm running the wrong OS for the game. I guessed it was a Steam Play issue, restarted Steam and at that point the game folders were empty and Steam initiated the download again. The filesystem for all of my Steam games is XFS on a LVM logical volume reserved for the games.

sputniktr02 commented 6 years ago

I can confirm the issue. Most of my games showed up in the update queue and i thought it was another 0 byte updates or proton update but steam started to download whole games again deleting already downloaded game files so if the update starts there is no way but download the game once again. Even the one of them was finished hours ago. Even some games that doesn't show up in the update queue was deleted once i attempt to launch them. I have lost more than 7 games already. I am on Steam beta, would going back to stable channel help? I don' want to lose remaining games (near 1 TB of data)

My Specs: https://gist.github.com/sputniktr02/3f410eb3d6206ab7bd35b70c6a1bb12c

Edit: My libraries are on ext4 volumes. Games are downloaded on Linux. I have two external libraries and both are effected.

My setting for Steam Play screenshot_20180914_203653

kisak-valve commented 6 years ago

So, no changed steam settings besides enabling Steam Play for all game titles? I asked because this may have been related to #5745.

nilleairbar commented 6 years ago

Nope, though that issue reads pretty similar to our issue here. I guess it is a similar issue in that the most recent beta branch got disabled which leads to Steam deleting the Windows games.

ghost commented 6 years ago

Nope, though that issue reads pretty similar to our issue here. I guess it is a similar issue in that the most recent beta branch got disabled which leads to Steam deleting the Windows games.

At first I was thinking it was a problem from sharing the Drive with Windows downloaded ones and the games becoming available with Proton, since I didn't remember doing anything other than testing that before it happened.

But if a branch was disabled then I suppose that could be a reason that it had to re-download everything to swap to a different one. Kind of lame though.

nilleairbar commented 6 years ago

But if a branch was disabled then I suppose that could be a reason that it had to re-download everything to swap to a different one. Kind of lame though.

That's actually my guess. The games were configured to be run with the Beta branch of Proton, that got dumped with the full release and the client identified those games as Win games without Proton attached so dumped those folders.

ghost commented 6 years ago

But if a branch was disabled then I suppose that could be a reason that it had to re-download everything to swap to a different one. Kind of lame though.

That's actually my guess. The games were configured to be run with the Beta branch of Proton, that got dumped with the full release and the client identified those games as Win games without Proton attached so dumped those folders.

I think its a good guess =)

Plagman commented 6 years ago

The new Beta client should improve behavior in that situation.

martynhare commented 6 years ago

This happened to me and made me very angry at the time as I only have 8Mb ADSL broadband. I hope the new client does fix this.

CentralPython commented 6 years ago

The new Beta client should improve behavior in that situation.

Has the beta client version of that fix been released fully into the stable client side yet? I would appreciate an update straight away with the fix so that when Proton does get updated I myself won't loose any game that was downloaded.

tuxtergames commented 5 years ago

Its happen here today with me, I spent my last night playing warframe, now steam re-downloaded 19GB of my game and Rise sons of rome too, more 24GB, holly hell its really anoying, even with my 1MB of internet, almost a day do re-download the game, check here steam update the beta client of proton to 3.7.8.

kisak-valve commented 5 years ago

Hello @tuxtergames, are you using the beta for Steam's client (not Proton)?

tuxtergames commented 5 years ago

Hello @tuxtergames, are you using the beta for Steam's client (not Proton)?

Sorry, I forgot to left here, I'm using the stable client of steam, with proton beta 3.7.8, and I didn't make anything, just turn off my computer last night and turn on today.

kisak-valve commented 5 years ago

Right, so that's older than the improved behavior changed in the Steam client beta a couple weeks back.

tuxtergames commented 5 years ago

Right, so that's older than the improved behavior changed in the Steam client beta a couple weeks back.

This make no sense, fixed for beta client and not stable?

mistertux commented 5 years ago

Can also confirm, this happened to me as well. All steamplay games were removed, the option "enable steamplay for all other titles" was disabled after the last client upgrade. I hope this doesn't happen again. I am running Arch Linux, Steam Client Beta version 1548107472. I have been on the beta for a long time, and steam is updated regularly. I use the 3.16-6 beta for proton.

kisak-valve commented 5 years ago

Hello @mistertux, you've described #5901 as a side effect of "Fixed an issue with invalid Steam Play tool selections if user had previously opted in to enable Steam Play for all titles. (Note: this will cause a one-time reset of all Steam Play global and per-app selections to the default state)." in the 2019-01-18 Steam client beta update.

The issue described here is Steam Play games getting deleted when the variant of Proton in use is removed. The fix for this from back in September should have made it into Steam's stable client and the issue tracked here should be resolved.

If someone comes across this specific scenario, let me know and I can re-open this issue report.

Saroufim commented 5 years ago

I just came across this. Steam just deleted all my proton games because I unticked and reticked the option to enable steam play for all titles. All the games except Elder Scrolls Online were deleted and queued again to be downloaded.

fsyy commented 5 years ago

same here. steam wanted to update steam client, then it began to loop the update. so i did a reset. after that steamplay for all games was unticked, so i activated it, and half of my games where gone.

cookiEoverdose commented 5 years ago

Happened to me too (proton 4-11-1).

Saroufim commented 5 years ago

@kisak-valve with 3 different people still experiencing the bug, perhaps it's time to reopen this again?

Additional info from my side: The bug seems to happen a title is using a specific proton version and that version is deleted. Steam turns off steamplay for that game and reenabling it with a valid proton version wipes it and redownloads it again. Similarly, turning steamplay off and back on wipes most of the titles.

random2324 commented 4 years ago

Just faced this too. I had custom proton versions installed. For some unknown reason it failed to detect them, so I switched to proton 4.11-11. I clicked on play but it told me "Wrong platform". Now some of my games are deleted. Even ones I didnt tried to play. But some do still wrong and doesnt need to redownload.

Really strange behavior. Using up to date Steam Beta Client.

random2324 commented 4 years ago

And it just happend again. Lost again 100 gigs of content. This time things were different: I didnt opened Steam for a week. Once opened it installed a steam update. Next it updated some linux native games properly. There was also some updates for proton games. But these were all zero in size. When I opened Steam for the next time, it also updated steam again. But now, it showed me lot of games in the download queue and all most of them were complete re downloads.

So I think the problem is, that it sometimes doesnt see proton installed. I use custom proton from tk glitch and enabled it globally. Maybe thats a bad idea? I probably should use latest official proton version for global enable or enable proton specifically.

The thing is that I cant understand the rationale behind this mechanism. I mean I understand that its not correct to have game files installed for the wrong platform and that Steam has to check for correctness BUT if there are no game files for the current system available anyway, why do you have to uninstall everything without giving any information to the user? Why cant it prompt and say "Incorrect game files for the current platform detected, delete all?" And you can choose to say NO! Because Im a super experimental user and I like to keep.

blastermaster77 commented 4 years ago

I got kind of the same problem when I switch off steamplay, on settings and then when I enbaled it, it started to download my last proton game that I launched the others where ok, did this with 2 more games and they did get deleted and redownloaded, the proton games that I did not launch they are still intact so the problem might be with manually switching proton versions on that game or deselecting the steam play option, please test to see if what happens to me happens to someone else.

se5a commented 4 years ago

I've got something similar happen in steam feb 11 2020.

I was messing around with trying to get Mech Warrior Online to run in proton, trying different proton versions, the dropdown box also includes "Steam Linux Runtime" unsure what this was at the time but clicked it anyway just to see what would happen. MWO is now re-downloading the whole 20gb. (even though it doesn't have a native client). switched it back to proton 5.x but it's still downloading it all. this option needs to come with a popup warning. and should probilby be disabled for games that do not have a native Linux client.

kisak-valve commented 4 years ago

Hello @se5a, you encountered https://github.com/ValveSoftware/steam-runtime/issues/200, not the issue reported here.

random2324 commented 4 years ago

Just hit this again. I actually should be smart enough now to keep a backup of all files but unfortunately I'm dumb. Anyway in my case it has probably something to do with custom proton version. I removed some versions because I needed disk space but this broke some games again. You really have to get alerted if you see 0 Byte updates. Its very likely Steam took the opportunity and just freed some disk space for you.

Different this time was that I couldn't reinstall my games. First steam was crashing when I tried to reach the properties tab then I launched steam from command line and it didnt crash. Strange, as I actually wanted to see the crash backtrace. Another strange thing is that even though the files are completely wiped, the games are still shown as installed in library. When you launch it says it cant find game exe. But trying file integrity check on them also doesnt work. It completes the check very quickly without downloading a single byte, stating everything OK.

The solution to this was to force a specific proton version for the games. Once doing this, the download started immediately.

Conclusion is that Steam is still missing a fallback mechanism. If a game was linked to a specific proton version and this version is no longer available, it should just fallback to the last installed stable one.

DanMan commented 4 years ago

Nothing ought to happen until you close the whole settings dialog. Instead it immediately changes files the moment you choose something different in the Proton settings (switching version, enable/disabling it altogether). That's bound to mess up people's files eventually.

fsyy commented 4 years ago

Just hit this again. I actually should be smart enough now to keep a backup of all files but unfortunately I'm dumb. Anyway in my case it has probably something to do with custom proton version. I removed some versions because I needed disk space but this broke some games again. You really have to get alerted if you see 0 Byte updates. Its very likely Steam took the opportunity and just freed some disk space for you.

Different this time was that I couldn't reinstall my games. First steam was crashing when I tried to reach the properties tab then I launched steam from command line and it didnt crash. Strange, as I actually wanted to see the crash backtrace. Another strange thing is that even though the files are completely wiped, the games are still shown as installed in library. When you launch it says it cant find game exe. But trying file integrity check on them also doesnt work. It completes the check very quickly without downloading a single byte, stating everything OK.

The solution to this was to force a specific proton version for the games. Once doing this, the download started immediately.

Conclusion is that Steam is still missing a fallback mechanism. If a game was linked to a specific proton version and this version is no longer available, it should just fallback to the last installed stable one.

Same thing happened to me too.