ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.19k stars 174 forks source link

Wrong file chooser in integrated PDF viewer #7383

Open inguin opened 3 years ago

inguin commented 3 years ago

Your system information

Please describe your issue in as much detail as possible:

Some games like Torchlight or Overlord II have an Additional Content section with a link to their game manual on their library page. The manual opens in an integrated PDF viewer with a very limited feature set.

The PDF viewer has a download button in the top right corner, but it does not work as expected. The button opens a file chooser that asks for an existing file. The selected file will be overwritten without confirmation. A proper file chooser should ask for a destination folder instead.

Steps for reproducing this issue:

  1. Open the library page of a game with a PDF manual in its Additional Content section
  2. Open the manual
  3. Click the Download icon in the top right corner
inguin commented 3 years ago

This seems to have changed since I filed the issue. Manuals are now opened in an external web browser rather than the Steam client. That's good enough for me, so feel free to close the issue if that's the intended behavior.

kisak-valve commented 3 years ago

Issue can be reproduced with the View the manual link in Torchlight's store page.

inguin commented 3 years ago

OK, thanks for the note. Then the change of behavior I see must be due to the configuration of my desktop environment.

kisak-valve commented 3 years ago

The change sounds like "Fixed some game manuals opening inside of the Steam client instead of in the user's browser." in the 2020-11-12 Steam client beta update.

inguin commented 3 years ago

The change sounds like "Fixed some game manuals opening inside of the Steam client instead of in the user's browser." in the 2020-11-12 Steam client beta update.

I'm not opted into Beta, but the according to this announcement the December 8 update for the default branch includes the same change. Either way, I'm now happy with this.