ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.16k stars 173 forks source link

Screenshot of non Steam games can't be uploaded #9335

Open strycore opened 2 years ago

strycore commented 2 years ago

Your system information

Please describe your issue in as much detail as possible:

When taking a screenshot of a non Steam game and trying to upload it, a notification appears saying "Failed to upload screenshot" Screenshots of Steam games or of the SteamOS UI upload without issue.

Steps for reproducing this issue:

  1. Add a non Steam game to the Deck
  2. Take a screenshot with Steam + R1
  3. Try uploading it to Steam
  4. Message "Failed to upload screenshot" appears
TTimo commented 2 years ago

Hello,

Since the game doesn't exist on the Steam servers, so there is nowhere to upload and store screenshots for it. This is unlikely to change as it would mean running a free image hosting service.

strycore commented 2 years ago

I figured it was something like that but on the other hand it's perfectly possible to upload screenshots of the Deck UI to Steam which isn't tied to any game at all. I would have expected screenshots of non-Steam games to be considered as non game screenshots as well.

TTimo commented 2 years ago

You're right. Screenshots are tied to your Steam account, so maybe it'd make sense if it could take screenshot uploads from non-steam games. The origin shouldn't really matter.

NightHammer1000 commented 2 years ago

Maybe a Option to Upload these kind of Screenshots somewhere else like imgur?

arrowgent commented 2 years ago

you can put them in your "artwork" section of your profile

generally if you dont own a game in your library you cant upload screenshots or videos to that appid

ImBoop commented 2 years ago

I've uploaded screenshots of non-Steam games to Steam without issue on the desktop client, so I think this should be possible.

iennonno commented 1 year ago

Not really sure why there are people stating the issue is non-Steam games. It’s not. I have screenshots from the early 10s of World of Warcraft and more. This is a valid issue.

Variapolis commented 1 year ago

This would be nice to have fixed considering a large portion of people who use SteamOS are SteamDeck users that are emulating games which are going to be non-steam.

And as was stated previously. Uploading non-steam games works everywhere except in the actual Deck Game UI mode.

safijari commented 1 year ago

The reason for this is that the appID for nonsteam games is being truncated when a screenshot is saved. It's supposed to be a 32 bit unsigned integer but for some reason the last few bits get stripped before the screenshot is saved. Because of this Steam has no way of knowing which app the screenshots belong to. This is why they don't show up under the "your stuff" section, and why you can't upload them (the Steam client tries to match the folder of the screenshot with an appid and cannot do so).

Source: I'm the author of the Shotty plugin and had to navigate this mess to get the correct app names when aggregating screenshots.

yalopov commented 9 months ago

At a bare minimum, it should store all screenshots in a less obscure picture folder like ~/Pictures or something like that, right now we need to switch to desktop mode, navigate to /home/deck/.local/share/Steam/userdata, search for any screenshots folders, go through all of those until finding the one you need, which is painful.