search

ValveSoftware / steam-for-linux

Issue tracking for the Steam for Linux beta client
4.23k stars 174 forks source link

[New Steam UI] Browse button does nothing when adding a non-steam game #9447

Open azzzertyy opened 1 year ago

azzzertyy commented 1 year ago

Your system information

Please describe your issue in as much detail as possible:

As title, when pressing the browse button to browse for a game on your hard drive when adding a non-steam game, the button does nothing.

Steps for reproducing this issue:

  1. Attempt to add a non-steam game
  2. Click browse
NoGoat commented 1 year ago

Just checked and the browse button doesn't work anywhere.

If you have already added a game before updating, try opening the properties for the game and click Browse. That doesn't work either

XimTheCookie commented 1 year ago

Also having this problem, is there any workaround to add a non-steam game?

tobiuchiha7 commented 1 year ago

Having this issue on SteamOs 3.5 as part of the main channel for updates.

DanMan commented 1 year ago

Works for me on latest beta. Fedora 38, Gnome, X11, Nvidia.

Steam Version:  1685572056
Steam Client Build Date:  Wed, May 31 23:57 UTC -08:00
Steam Web Build Date:  Wed, May 31 22:00 UTC -08:00
Steam API Version:  SteamClient020
Kagukara commented 1 year ago

Doesn't work for me:

Your system information

DaRealNim commented 1 year ago

I am encountering this issue. But contrary to @NoGoat, the browse button works and opens nautilus when I browse installed files for a game. It just does nothing for "add a Non-Steam game".

My system information Steam client version (build number or date): 1685572056 Distribution: Arch Opted into Steam client beta?: Yes Have you checked for system updates?: Yes DE: GNOME 44.1 WM: Mutter

sbarrack commented 1 year ago

Ditto, button does nothing. @XimTheCookie I did figure out how to cheese it by creating a new menu shortcut in my DE pointing to the .exe (exo-desktop-item-edit --create-new ~/.local/share/applications). Steam then puts it in the list of programs it detects when you go to add a non-Steam game so that you don't need to browse for it. After adding it, I deleted the new .desktop file in .local/share/applications.

Kagukara commented 1 year ago

Still doesn't work for me and was also pushed to the non beta. So there is now no way of adding non-steam games to steam unless you use sbarracks workaround:

Your system information

kisak-valve commented 1 year ago

Hello @Kagukara, please copy the contents of Steam Runtime Diagnostics from Steam (Steam -> Help -> Steam Runtime Diagnostics) and put it in a gist, then include a link to the gist in this issue report.

Kagukara commented 1 year ago

@kisak-valve here is the gist.

kisak-valve commented 1 year ago

https://gist.github.com/Kagukara/5a783a52503e297e8460875189bc8607#file-steam-runtime-system-information-L2904-L2922 looks like the key details. I'm guessing that the xdg-desktop-portal-wlr system package would be the nearest match with sway to test.

Kagukara commented 1 year ago

xdg-desktop-portal-wlr is already installed on my system.

Kagukara commented 1 year ago

@kisak-valve it looks like xdg-desktop-portal-wlr doesn't have a file chooser which is why its not working. wiki.archlinux link to "List of backends and interfaces"

ManIVIctorious commented 1 year ago

Just retried, it now gets a little further on current beta, but still is unusable...

Steam Version: 1686880776 Steam Client Build Date: Fri, Jun 16 03:41 UTC -08:00 Steam Web Build Date: Fri, Jun 16 03:10 UTC -08:00 Steam API Version: SteamClient020

If I click the + button in Settings/Storage the file chooser opens and it is possible to select a directory. Unfortunately, steam seems to be unable to access the games stored there (I already used that directory previously via flatpak override so the games are definitely installed in that directory). I tried opening the steam flatpak in the terminal and got the following error log

flock /run/user/60318/doc/8cc75243/SteamLibrary/libraryfolder.vdf LOCK_SH failed. errno = 38
CAppInfoCacheReadFromDiskThread took 128 milliseconds to initialize
Failed to init SteamVR because it isn't installed
flock /run/user/60318/doc/8cc75243/SteamLibrary/steamapps/appmanifest_1054830.acf LOCK_SH failed. errno = 38
flock /run/user/60318/doc/8cc75243/SteamLibrary/steamapps/appmanifest_11450.acf LOCK_SH failed. errno = 38
flock /run/user/60318/doc/8cc75243/SteamLibrary/steamapps/appmanifest_1245040.acf LOCK_SH failed. errno = 38
flock /run/user/60318/doc/8cc75243/SteamLibrary/steamapps/appmanifest_1255980.acf LOCK_SH failed. errno = 38
flock /run/user/60318/doc/8cc75243/SteamLibrary/steamapps/appmanifest_12710.acf LOCK_SH failed. errno = 38
.
.
.

Note: truncated output for just a few selected app ids, since it always seems to be LOCK_SH failed. errno = 38. Let me know if I can provide you with any more useful data about the issue.

ZeroKun265 commented 1 year ago

I have this problem too, when i click browse nothing works, not even a pop up. Running on arch Linux, system up to date, steam version 1686880776

kisak-valve commented 1 year ago

Hello @ZeroKun265, if clicking browse doesn't open a dialog, that means that xdg-desktop-portal isn't in a working configuration. #9584 is tracking the lack of fallback in that scenario.

PagnuM commented 1 year ago

Had the same issue, installing the "xdg-desktop-portal" package solved it, a bit weird that it used to work fine before

ZeroKun265 commented 1 year ago

Hello @ZeroKun265, if clicking browse doesn't open a dialog, that means that xdg-desktop-portal isn't in a working configuration. #9584 is tracking the lack of fallback in that scenario.

But i have xdg-desktop-portal-kde inatalled..

kisak-valve commented 1 year ago

Please copy the contents of Steam Runtime Diagnostics from Steam (Steam -> Help -> Steam Runtime Diagnostics) and put it in a gist, then include a link to the gist in this issue report.

MatthewJPretty commented 1 year ago

@kisak-valve Here is Gist with the same issue on hyprland, wayland, Arch.... https://gist.github.com/MatthewJPretty/efdfed22ccfb2cecd397d9aed3f1a4ed

xXJohan-JoestarXx commented 1 year ago

I know that update was bad but now this..?

nesnera commented 1 year ago

is there any workaround to add a non-steam game?

@XimTheCookie: This works for me - https://steamcommunity.com/app/221410/discussions/0/365172547938643895/#c6717729343884776040

azzzertyy commented 1 year ago

It does seem this is an issue of dependencies and nothing else. xdg-desktop-portal should be added as a dependency on all package managers for steam, as highlighted in this post on the arch bug reporter.

https://bugs.archlinux.org/task/78625?project=5&string=steam

mindlessp0tatoe commented 1 year ago

Can confirm that on Arch, all i had to do is install xdg-desktop-portal.

sudo pacman -S xdg-desktop-portal

After installing, you can browse from steam client like normal (no need to restart PC or Steam)

System Info: Steam Version: 1687386907 Distribution: Arch Linux Kernal: 6.3.9 DE: KDE Plasma (5.27.6) WM: KWin

Alrodemoa commented 1 year ago

Can also confirm on Arch I just install it and restart Steam sudo pacman -S xdg-desktop-portal

System Info: Steam Version: 1687386907 Distribution: Arch Linux Kernal: 6.3.9-zen1-1-zen DE: KDE Plasma 5.27.6 WM: KWin

Kagukara commented 1 year ago

I have xdg-desktop-portal downloaded on Arch and it doesn't work. You may have xdg-desktop-portal-kde installed which is why it works.

https://wiki.archlinux.org/title/XDG_Desktop_Portal#List_of_backends_and_interfaces

purplebar0 commented 1 year ago

I noticed that the file picker in the context of choosing library locations (substituted with library_folder_add) now falls back to the VGUI dialogue, can you please assign the fallback to other contexts too (Chat, non-Steam game selector, web browsing)?

I hesitate using desktop portals just because Steam felt like going fancy, and there's no loss in using what's already there if the desktop portal dependency is not met.

SpirTBBX commented 1 year ago

I am running EndeavourOS with KDE Plasma.

I had installed xdg-desktop-portal-kde and it didn't work. Installing xdg-desktop-portal allowed me to finally get it to work (without running steam with the old UI)

Kagukara commented 1 year ago

I am running EndeavourOS with KDE Plasma.

I had installed xdg-desktop-portal-kde and it didn't work. Installing xdg-desktop-portal allowed me to finally get it to work (without running steam with the old UI)

That's because xdg-desktop-portal-kde is required by xdg-desktop-portal. If you just have one of them it won't work, you need both. Any backend with a file chooser + xdg-desktop-portal will make it work.

https://wiki.archlinux.org/title/XDG_Desktop_Portal#List_of_backends_and_interfaces

ManIVIctorious commented 1 year ago

I think I have a slightly different problem at hand:

Since quite a few years I am using the steam flatpak from flathub. Due to my home directory being on a rather small drive I added the following override:

[Context]
filesystems=/mnt/media/SteamLibrary

when the portal support was activated in beta I hoped I could remove this override and just reselect the given directory, unfortunately this does not seem to be the case. Re-enabling this override fixes the library access, although, since I am syncing all my overrides between my machines, I would really love to get rid of it

RinLovesYou commented 1 year ago

Browse button happily works on x11, but picking anything will NOT put it in the list. it's impossible to add a non-steam game.

jvelezVOX commented 11 months ago

"> Had the same issue, installing the "xdg-desktop-portal" package solved it, a bit weird that it used to work fine before"

Installing this pack and xdg-desktop-portal-wlr worked for me on Steam 1698777785 on Ubuntu 22.04 fresh install, it also seems that you cant click on the selected library to make it default if you click outside of the pixels of the letters in the label.