ValveSoftware / steamworks-vr-api

Source for the Steamworks VR API
Other
137 stars 30 forks source link

vr_messages.pb.h and .cc not being generated #17

Closed nickludlam closed 10 years ago

nickludlam commented 10 years ago

I have an issue during the build process where I end up with no vr_messages.pb.h and vr_messages.pb.cc. This happens for each project where there's a dependency on those files.

It looks like there's a pre-compile script failure, and I see a warning saying warning: directory does not exist on line 1. Unfortunately I'm not as familiar with vpc as I'd need to be to debug this further, but it seems like an invocation of protoc is failing somewhere. Can I see any trace logging of what's bombing out?

Thanks, Nick

JoeLudwig commented 10 years ago

What platform are you building on?

On Apr 22, 2014 7:06 AM, Nick Ludlam notifications@github.com wrote:

I have an issue during the build process where I end up with no vr_messages.pb.h and vr_messages.pb.cc. This happens for each project where there's a dependency on those files.

It looks like there's a pre-compile script failure, and I see a warning saying warning: directory does not exist on line 1. Unfortunately I'm not as familiar with vpc as I'd need to be to debug this further, but it seems like an invocation of protoc is failing somewhere. Can I see any trace logging of what's bombing out?

Thanks, Nick

— Reply to this email directly or view it on GitHubhttps://github.com/ValveSoftware/steamworks-vr-api/issues/17.

nickludlam commented 10 years ago

Apologies, should have included that! I'm on Windows 7 64-bit and have both VS2010 and 2012 installed

nickludlam commented 10 years ago

I've grabbed the build output and made a gist. https://gist.github.com/nickludlam/11229375

From what I can tell, it has an issue as my users directory has a space in it, so in the output there's a line:

C:\Users\Nick : warning : directory does not exist.

instead of it being C:\Users\Nick Ludlam\. Can it be that spaces are not being escaped somewhere in the build process?

JoeLudwig commented 10 years ago

That is almost certainly what it is. Does if you copy the whole directory into something that doesn't have a space then run VPC and try to build?

The fix is likely to add \" around the $SRCDIR/whatever references in https://github.com/ValveSoftware/steamworks-vr-api/blob/master/src/vpc_scripts/protobuf_builder.vpc

nickludlam commented 10 years ago

Yeah I can build it just fine when I move the repo out of its default directory in Documents. I'll have a go at patching the protobuf_builder.vpc file to see if I can get it accepting SRCDIR paths with spaces

nickludlam commented 10 years ago

I couldn't find a good way to escape the path so I'm not sure if this should be noted down in the README as a gotcha, or whether someone else wants to have a go at fixing it.

I've done this before in batch scripts using SET SRCDIR="C:\Something with spaces\" and then reference it with %SRCDIR% but I'm unclear about the context in which the generated code gets run.

JoeLudwig commented 10 years ago

Added a note to the readme to hopefully keep other people from running into this.

https://github.com/ValveSoftware/steamworks-vr-api/commit/eb4f0a6ccdef7a88e9ce729d03d8b1a35533fc64

And then fixed the word wrapping here: https://github.com/ValveSoftware/steamworks-vr-api/commit/afe1f686dd23f0a65f908e47f6b446231af29ae0