search

ValveSoftware / vogl

OpenGL capture / playback debugger.
MIT License
1.42k stars 126 forks source link

Doesn't compile in macos #224

Open Siri94 opened 6 years ago

Siri94 commented 6 years ago 
[ 27%] Built target voglcore
[ 29%] Built target voglgen
[ 29%] Built target voglgen_make_inc
[ 47%] Built target voglcommon
[ 48%] Building CXX object src/voglreplay/CMakeFiles/vogl.dir/replay_tool_trace.cpp.o
In file included from /Users/shk/Library/Mobile                                            ^     ~
/Users/shk/Library/Mobile Documents/com~apple~CloudDocs/MainProjects/SMK/vogl/src/voglreplay/replay_tool_trace.cpp:129:58: error: ordered comparison between pointer and zero ('char *' and 'int') [Semantic Issue]
    if ((file_utils::get_exec_filename(buf, sizeof(buf)) <= 0))
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~
289 warnings and 1 error generated.
make[2]: *** [src/voglreplay/CMakeFiles/vogl.dir/replay_tool_trace.cpp.o] Error 1
make[1]: *** [src/voglreplay/CMakeFiles/vogl.dir/all] Error 2
make: *** [all] Error 2

And my solution is like that: https://github.com/ValveSoftware/vogl/commit/6846f4e8df90fc762fe241e2384a1973a9bf5784

225 warnings generated.
[100%] Linking CXX executable ../../../ktxtool64
[100%] Built target ktxtool

If it seems no problem, close it.

rlalance commented 5 years ago

Confirmed. Does not currently build.