search

ValveSoftware / wine

Wine with a bit of extra spice
Other
1.23k stars 235 forks source link

winsock: Missing TCP_KEEP{ALIVE,CNT,INTVL} options. #225

Open ProjectSynchro opened 5 months ago

ProjectSynchro commented 5 months ago

Hi,

I understand that this wouldn't effect any Steam games (at least to my knowledge) but in the latest RC for Star Citizen's RSI Launcher, the launcher fails to download files due to some missing IPPROTO_TCP options in winsock.

The particular fixme in the logs is: 00d8:fixme:winsock:setsockopt Unknown IPPROTO_TCP optname 0x00000003

I think the specific missing optname is TCP_KEEPALIVE, but I am unsure.

I found the merge request upstream that implements this: https://gitlab.winehq.org/wine/wine/-/merge_requests/5195

Could these commits get pulled into Valve's wine fork?

Cheers.

LucyDemooon commented 4 months ago

pls

Etaash-mathamsetty commented 4 months ago

Replying to https://github.com/ValveSoftware/wine/issues/225#issue-2203642183

if you know how could you please compile proton-tkg or proton with that patch included and see if it works?

ProjectSynchro commented 4 months ago

Can confirm that the following merge-request includes all of the needed patches to get the RSI Launcher to work: https://gitlab.winehq.org/wine/wine/-/merge_requests/5195

timmy31113 commented 2 months ago

This does affect Steam games as well. ZUSI 3 (app ID 1040730) uses TCP sockets to communicate with an external process (that's the app ZusiDisplay mentioned in the merge request) for various rendered computer screens in game. Currently, on Proton 9.0-2 or Proton Experimental, all these screens are just black.

See the game specific issue thread over in the Proton repo: https://github.com/ValveSoftware/Proton/issues/4462#issuecomment-1992518888

Player Eldomtom2 on ProtonDB reports that a self-compiled Proton using the upstream Wine sources after commit 8dc5242e does indeed fix those screens