search

VanOns / laraberg

A Gutenberg implementation for Laravel
GNU General Public License v3.0
1.33k stars 144 forks source link

laravel filemanager 6.x update breaks laraberg #63

Closed tpaksu closed 4 years ago

tpaksu commented 5 years ago

The laravel-filemanager dev-master branch seems to be changed a lot and the file/image selections don't work in laraberg, because now they pass an object instead of url/path tuple as the window.opener.setURL callback arguments.

https://github.com/UniSharp/laravel-filemanager/blob/78aeffe12087b1ba43cdbd5e48385bb0e5221b0e/public/js/script.js#L193-L198

and laraberg is using this line to get the images:

https://github.com/UniSharp/laravel-filemanager/blob/78aeffe12087b1ba43cdbd5e48385bb0e5221b0e/public/js/script.js#L599

The fix is needed for people using Laravel 6.X because the laravel-filemanager package has the change on the Laravel 6.X update. The fix should be applied here:

https://github.com/VanOns/laraberg/blob/8709ea0e61b0fac52e29ba7257a03ed57434174b/src/resources/js/laravel-filemanager/index.js#L26-L35

But I couldn't compile the javascript with the included webpack configuration.

Environment

Additional context Testing with Laravel 6.3 on Laragon, PHP 7.3, nginx with php-fpm running, laravel-filemanager dev-master branch

JMoralSquare1 commented 4 years ago

Hi!! Any update about this? thanks! ;)

tpaksu commented 4 years ago

@JMoralSquare1 I fixed all and added some new things in my own fork if it. This seems like abandoned.

JMoralSquare1 commented 4 years ago

@tpaksu , thanks I will take a look ;)

tpaksu commented 4 years ago

@tpaksu , thanks I will take a look ;)

Sorry I forgot to mention, the code is in the lfm-fix branch.

hvlucas commented 4 years ago

Any update or workaround for this issue?

LonnyX commented 4 years ago

@JMoralSquare1 did you take a look on the fix? We are still waiting and it's a breaking change

jam1e commented 4 years ago

@tpaksu , thanks I will take a look ;)

Sorry I forgot to mention, the code is in the lfm-fix branch.

How would I go about using your fix in my project? I seem to be having issues with requiring in your fork of this package.

tpaksu commented 4 years ago

@jam1e since I continued developing on that branch, I didn't register it to packagist, you can fork it and register it yourself, but before forking you can try it by adding the fork in your composer.json file.

LonnyX commented 4 years ago

@jam1e since I continued developing on that branch, I didn't register it to packagist, you can fork it and register it yourself, but before forking you can try it by adding the fork in your composer.json file.

@tpaksu I just tried your branch and it seems that the fix doesn't works... Are you sure it's fixed?

tpaksu commented 4 years ago

@jam1e can you try with this file manager? It's a fork of unisharp one. I don't know what I've changed but these two should work.

https://github.com/tpaksu/laravel-filemanager

LonnyX commented 4 years ago

@tpaksu Even with your fix, it doesn't works :/ Maybe this should stay Open until it's fixed by the team.

@mauricewijnia please check this

tpaksu commented 4 years ago

@LonnyX I don't know, I gave up to work on laraberg but left the repositories open in case someone needs some code about localization, but at where I left, it should be working. Maybe it needs a rebuild on gutenberg to get working again, I don't know. I'll leave it open then.

MuhammadTaha commented 4 years ago

it doesn't work with laravel 5.8 as well