search

VanRoy / spring-data-jest

Spring Data Implementation for Jest
Apache License 2.0
227 stars 78 forks source link

Respect custom highlight builder from SearchQuery object. #144

Closed kidylee closed 4 years ago

kidylee commented 4 years ago

Symptom

Current JestElasticsearchTemplate doesn't respect custom highlight from SearchQuery.

Problem

The template re-creates highlight builder when it detects highlight fields been set.

Solution

Respect the highlight builder from SearchQuery object and support the old re-creation way for backward compatibility.

VanRoy commented 4 years ago

@kidylee Thanks a lot for this improvement. Do you think you have the posibility to add a unit test to validate the fix ?

kidylee commented 4 years ago

I will do it when I have time.

kidylee commented 4 years ago

Unit test has been add, please have a check, thank.

VanRoy commented 4 years ago

@kidylee Thanks I will check it right now