search

VanceCole / simplefog

A module for FoundryVTT that lets you draw fog of war manually
MIT License
9 stars 21 forks source link

SightLayer method has been renamed. Broken compatibility with 0.7.6. #13

Open donpezet opened 3 years ago

donpezet commented 3 years ago

SimpleFog 0.1.11 was a little flaky under FoundryVTT 0.7.5, but it still basically worked. However, it is completely broken in Foundry VTT 0.7.6. Loading a map with the module enabled generates the following error in the console: You are calling the SightLayer#update method which has been renamed to SightLayer#refresh to be consistent with other PIXI objects.
update @ foundry.js:39500
onClick @ controls.js:21
_onClickTool @ foundry.js:19874
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
The drawing tools show up outside of the map, but disappear when you move your mouse over the actual map. No fog shows up on the map (new or previously drawn). I suspect this is because it cannot update the sight layer due to the method being renamed.

donpezet commented 3 years ago

Additional information: My server is running FoundryVTT 0.7.6 using NodeJS 14.15 on top of Ubuntu Linux 20.04.1 with all updates applied. My client is running Google Chrome 86.0.4240.183 on Windows 10 v2004.

donpezet commented 3 years ago

Well, I did a little more experimenting. I updated the module to replace calls to sight.update to instead call sight.refresh. That cleared the error and made the drawing tools work again. However, the fog canvas is not aligned with the underlying map so it looks like this is going to be a bigger issue than a simple renamed method.

jalensailin commented 3 years ago

I am also experiencing this issue. Thanks for the wonderful mod so far

Sonny-Crockett commented 3 years ago

Yes amazing mod but I had to disable it for the moment.

crhampton1 commented 3 years ago

Just providing an update on all open issues with Vance's module. This has been taken over by the League of Foundry Developers. This will help prevent lapses in updates. I have taken over as main contributor. All new releases and updates will be managed through the new forked version. We will get the link updated on the Foundry VTT website, but you may want to go ahead and switch. We have already updated and added some new features.

To install this fork, you first will have to uninstall the old module, then install based on this manifest url. You should not lose your fog on maps you have used previously.

https://raw.githubusercontent.com/League-of-Foundry-Developers/simplefog/master/module.json