search

VanceCole / simplefog

A module for FoundryVTT that lets you draw fog of war manually
MIT License
9 stars 21 forks source link

Fog Menu becoming unresponsive. #15

Open Nedrapter opened 3 years ago

Nedrapter commented 3 years ago

I'm using foundry 0.7.6 and the latest version of Simple Fog. After using the feature for a while and switching to another tool menu (usually the actor select), I cannot switch back to Simple Fog's "cloud" menu. Clicking it does nothing. All the other tool menu icons work. Refreshing the page fixes it, but it's too annoying as it happens often.

Sonny-Crockett commented 3 years ago

I think Foundry 7.6 borked something.

jalensailin commented 3 years ago

Definitely borked something. Hopefully someone can get this module working again soon cus i really liked it

SONDLecT commented 3 years ago

I'm seeing the same problem on .77, unfortunately. These are the errors I'm seeing load up in the console when I enable the simple fog layer, then click off to another tool, then try to return to the simple fog toolset.

image

fil7ercoffee commented 3 years ago

It isn't working for me at all, in v0.7.7 I hope someone can fix it, my hex crawl game is entirely dependent on this module :(

thadmiller commented 3 years ago

The cause of the issue appears to be the Foundry VTT code itself. SimpleFog works by creating a new layer - unfortunately, the newer versions of FVTT removed the extensibility and have hard-coded the layers. While the SimpleFog layer does get created in the canvas, FVTT then ignores that layer, so I don't think there's going to be a way to fix this module without FVTT being fixed first.

thadmiller commented 3 years ago

This certainly works better (tested in FVTT 0.7.7), but a new quirk seems to be introduced: when SimpleFog is the active layer, and I switch to a new scene, I lose the Brush Size tool (Brush Opacity remains). Switching off and back to SimpleFog returns both Brush Size and Opacity.

Anyway, thanks for your fix/fork - it's at least usable again.

I was able to fix this module, and just did a pull request. Can't promise it fixed everything but not getting any errors after testing this on all settings, switching maps, etc. Had one other person test too. Not sure if Vance is updating anymore, so feel free to switch to my forked version. https://raw.githubusercontent.com/crhampton1/simplefog/0.1.12/module.json

https://github.com/crhampton1/simplefog

thadmiller commented 3 years ago

I take that back - the Brush Size/Opacity values show up as soon as the SimpleFog layer is selected, without any of the tools selected. If the brush tool is selected, switching scenes works as it should. I still think it's a quirky behavior, but everything seems to be working. Thanks again.

crhampton1 commented 3 years ago

@thadmiller, I figured out what was causing that. Just fixed it if you want to update. That and an issue with the lighting and stuff appearing over the fog. Thanks! 0.1.13

crhampton1 commented 3 years ago

Just providing an update on all open issues with Vance's module. This has been taken over by the League of Foundry Developers. This will help prevent lapses in updates. I have taken over as main contributor. All new releases and updates will be managed through the new forked version. We will get the link updated on the Foundry VTT website, but you may want to go ahead and switch. We have already updated and added some new features.

To install this fork, you first will have to uninstall the old module, then install based on this manifest url. You should not lose your fog on maps you have used previously.

https://raw.githubusercontent.com/League-of-Foundry-Developers/simplefog/master/module.json