search

VanceVagell / kv4p-ht

Open source handheld ham radio project KV4P-HT
GNU General Public License v3.0
316 stars 35 forks source link

Refactor Arduino Code #39

Closed wsciaroni closed 3 weeks ago

wsciaroni commented 1 month ago

Closes #19

This MR seeks to simply move the code into functions.

I do not have hardware to test this.

I made a few functions that should reduce some duplication across the code. I plan to make a second pull request where I will try to make this a bit more object oriented.

VanceVagell commented 1 month ago

I see this still says WIP but it looks in decent shape. Are you planning to make more changes in this?

wsciaroni commented 1 month ago

I see this still says WIP but it looks in decent shape. Are you planning to make more changes in this?

I have branched from here to start a more thorough overhaul. The follow-on is #40

Other than that, this is completely untested, so please test it before merging.

VanceVagell commented 1 month ago

Per discussion with wsciaroni, this is code complete but needs to be tested on device (he does not yet have the board to test it himself).

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

wsciaroni commented 3 weeks ago

Instead of doing a partial upgrade with this PR, we will instead spend time on #40