VanceVagell / kv4p-ht

Open source handheld ham radio project KV4P-HT
GNU General Public License v3.0
316 stars 35 forks source link

[ESP32] Frequency values extracted from Android command string mistakenly include extra digit #64

Closed VanceVagell closed 3 weeks ago

VanceVagell commented 3 weeks ago

In the COMMAND_TUNE_TO handler in the ESP32 code, the tx frequency, rx frequency, tone, and squelch are extracted from the command message sent by the Android app (e.g. "146.700146.700000")

However, the indices used to extract the tx and rx frequencies are mistakenly going 1 character too far. For example, what should be "146.700" is instead read as "146.7001".

In practice this doesn't cause any major issues. Either the radio is ignoring the extra digit, or it's tuning ~100Hz off. But should definitely be fixed.