search

VandalByte / darkmatter-grub2-theme

Dark Matter GRUB Theme 👾💙
https://www.pling.com/p/1603282/
GNU General Public License v3.0
310 stars 15 forks source link

Auto-installer comments out GRUB_TERMINAL_OUTPUT #10

Closed LinuxHeki closed 2 years ago

LinuxHeki commented 2 years ago

Hi! Your theme is so cool! But when I installed with auto-installer it didn't work so I decided to fix it. I also added contributors in the install.py comment at the top and updated version.

VandalByte commented 2 years ago

Hey @LinuxHeki This script isn't actually compatible with fedora ( I am guessing you are a fedora user 😅) and I did fix this issue in the installation script on my other grub theme. I was actually planning to update this script in the next theme update which probably might be this week 🤔, not sure.

And yeah thanks for the contribution, this might help a lot of users 😉

I will merge this after I review the changes 👍

LinuxHeki commented 2 years ago

Not compatible? Run a script and comment out one thing is not compatible? Of course it is! It has grub2 support! And how did you know that I'm a feora user?

VandalByte commented 2 years ago

@LinuxHeki I think I got you confused. I was talking about my current installation script in this main repo, yours works fine, I checked it just now. And now about Fedora, as far as I have seen Fedora seems to be the only one that doesn't show grub theme out of the box _( ie due to the line GRUB_TERMINAL_OUTPUT="console")_ and that's how I guessed 🤷‍♂️

LinuxHeki commented 2 years ago

Yes I know. Running a script and then commenting one line seems compatible to me.