search

VandalByte / darkmatter-grub2-theme

Dark Matter GRUB Theme 👾💙
https://www.pling.com/p/1603282/
GNU General Public License v3.0
310 stars 15 forks source link

a bug with the solus theme #17

Closed Salsely closed 2 years ago

Salsely commented 2 years ago

Python terminal output:

($) Copying the theme directory ...

($) Editing the GRUB file ...

(!) An unexpected error occured while running the script. Installation was unsuccessful ...

(!) ERROR: 'NoneType' object has no attribute 'group'
VandalByte commented 2 years ago

Hi @basedcommiedev (1) Can you tell me which distro you are using? (2) Also can you show me the output of the following command

ls -l /etc | grep "-release"
medanisjbara commented 2 years ago

I had the same problem. I'm using arch linux, apparently arch has two files ending with "-release" 

$ ls -l /etc | grep "release"  #I used "release" instead of "-release" because grep interprets it as a flag even with double quotes 
-rw-r--r-- 1 root root      0 Dec  7 03:41 arch-release
lrwxrwxrwx 1 root root     21 Jan 11 23:09 os-release -> ../usr/lib/os-release

after some investigation i found out that arch-release file is an empty file. (totally empty) which used to contain information but now it's only purpose is to let some programs know that the distribution is arch. I don't know if there are other distributions who does the same. but the operating system identification data file is os-release symlink (archlinux uses systemd). I'm submitting a pull request that checks for the os-release first and only does a search if it doesn't exist since searching for that file seems in general systemd init system stores operating system identification data there. if anyone thinks there's a better solution to handle this. I personally think this is the optimal solution because I know how polular systemd is, but I have no idea about other init systems. so if someone thinks there's a better way to handle this please let me know.

VandalByte commented 2 years ago

Hi @medanisjbara I haven't used Arch that much so I'm a bit rusty on that. I will update this on my other theme script as well 😇 ( you can create a pull request for it also if you like ) And thanks a lot for your effort pal.

medanisjbara commented 2 years ago

I believe you can safely close the issue now. I just did the pull request on the other theme. I'm glad I was able to help ^^