search

VandalByte / darkmatter-grub2-theme

Dark Matter GRUB Theme 👾💙
https://www.pling.com/p/1603282/
GNU General Public License v3.0
310 stars 15 forks source link

Update install.py #21

Closed lagodimos closed 2 years ago

lagodimos commented 2 years ago

Added command line options to the installation script for selecting theme and automatically deleting previous version

e.g. sudo python3 install.py debian -y

debian: to install the debian style -y: to skip the confirmation message to delete the previous version (if exists)

VandalByte commented 2 years ago

Hi @Giann1s Thanks for taking your time and doing this amazing improvement to the install script.

Also a suggestion, maybe adding ( after line 157 ) the following lines would help avoid conflicts on installation, what do u think?

# In order to avoid a user inputting multiple theme-styles
# here number 3 includes, arg_list = ["FILE_NAME","THEME-STYLE","-y"]
if len(arg_list) > 3:
    raise Exception("Input of arguments exceeded")  # warning (also maybe change the warning message, mine looks imperfect)
lagodimos commented 2 years ago

Hi @vandalsoul, I made some more changes based on your suggestion. Of course you can make any modifications you want :)