VandersonQk / KuroReaderReleases

Apk releases from Kuro Reader and Kuro Reader Pro
https://kurotoshiro.dev/
30 stars 0 forks source link

"All Books" issue and other enhancements #14

Open PhilipElom opened 1 month ago

PhilipElom commented 1 month ago

In the All Books category, not all books have their Author's name showing despite that metadatum being filled out. And speaking of the Home Page, it would be nice to see it more detailed displaying the file name and directory, the actual book and other metadata (like Notes, Summary, Tags). It would be nice not to click each book to see this. Thank you for your work.

VandersonQk commented 1 month ago

I misunderstood the issue you reported via email, I didn't realize you were talking about the names of the artists/staff in the books, I thought it was about the main list of all the authors. I've fixed that, and now all authors are shown. (check the screenshots below, is that what you're talking about?)

As for showing more details, it's simple in the coding, but the UI part... there's not enough room. A simple example is the synopsis, on a regular smartphone (1080p screen, system set to small font size), only two lines of the synopsis would be visible in a comic with a two-line title. Using the system set to a large font size, there is no room at all. And I'm not going to increase the size of the items, it's already too big...

Examples:

PhilipElom commented 1 month ago

It doesn't really matter if the entire synopsis shows. At least, that little tidbit could pique or satiate a reader's curiosity as regards the comic he's about to read.

On Mon, May 27, 2024, 7:30 PM Vanderson Oliveira @.***> wrote:

I misunderstood the issue you reported via email, I didn't realize you were talking about the names of the artists/staff in the books, I thought it was about the main list of all the authors. I've fixed that, and now all authors are shown. (check the screenshots below, is that what you're talking about?)

As for showing more details, it's simple in the coding, but the UI part... there's not enough room. A simple example is the synopsis, on a regular smartphone (1080p screen, system set to small font size), only two lines of the synopsis would be visible in a comic with a two-line title. Using the system set to a large font size, there is no room at all. And I'm not going to increase the size of the items, it's already too big...

Examples:

-

Small font size Screenshot_2024-05-27-13-53-26-917_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/94951407-085e-47ab-850d-1cc301a8b0fc

Big font size Screenshot_2024-05-27-14-17-36-577_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/58f063e7-e7f3-4312-b161-77708e21ecc7

— Reply to this email directly, view it on GitHub https://github.com/VandersonQk/KuroReaderReleases/issues/14#issuecomment-2133917372, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA522JY4D7U73ZAHEWUWOPTZEN3STAVCNFSM6AAAAABIJBEHNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHEYTOMZXGI . You are receiving this because you authored the thread.Message ID: @.***>

PhilipElom commented 1 month ago
  1. I wouldn't mind if the UI looked just like the first screenshot with the smaller font. I would love it, in fact (with the file path included). It's just a matter of making the thumbnail larger and the fonts smaller.
  2. When I spoke about the Author issue, I meant that not all the books had their Author's name being displayed in the All Books category despite the metadata being filled out.

On Mon, May 27, 2024, 7:53 PM Philip Elom @.***> wrote:

It doesn't really matter if the entire synopsis shows. At least, that little tidbit could pique or satiate a reader's curiosity as regards the comic he's about to read.

On Mon, May 27, 2024, 7:30 PM Vanderson Oliveira @.***> wrote:

I misunderstood the issue you reported via email, I didn't realize you were talking about the names of the artists/staff in the books, I thought it was about the main list of all the authors. I've fixed that, and now all authors are shown. (check the screenshots below, is that what you're talking about?)

As for showing more details, it's simple in the coding, but the UI part... there's not enough room. A simple example is the synopsis, on a regular smartphone (1080p screen, system set to small font size), only two lines of the synopsis would be visible in a comic with a two-line title. Using the system set to a large font size, there is no room at all. And I'm not going to increase the size of the items, it's already too big...

Examples:

-

Small font size Screenshot_2024-05-27-13-53-26-917_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/94951407-085e-47ab-850d-1cc301a8b0fc

Big font size Screenshot_2024-05-27-14-17-36-577_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/58f063e7-e7f3-4312-b161-77708e21ecc7

— Reply to this email directly, view it on GitHub https://github.com/VandersonQk/KuroReaderReleases/issues/14#issuecomment-2133917372, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA522JY4D7U73ZAHEWUWOPTZEN3STAVCNFSM6AAAAABIJBEHNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHEYTOMZXGI . You are receiving this because you authored the thread.Message ID: @.***>

PhilipElom commented 1 month ago

Here are two screenshots of the issue. The first screenshot has the Authors' names right there. The second doesn't after I scroll down bit and then back up.

On Mon, May 27, 2024, 8:00 PM Philip Elom @.***> wrote:

  1. I wouldn't mind if the UI looked just like the first screenshot with the smaller font. I would love it, in fact (with the file path included). It's just a matter of making the thumbnail larger and the fonts smaller.
  2. When I spoke about the Author issue, I meant that not all the books had their Author's name being displayed in the All Books category despite the metadata being filled out.

On Mon, May 27, 2024, 7:53 PM Philip Elom @.***> wrote:

It doesn't really matter if the entire synopsis shows. At least, that little tidbit could pique or satiate a reader's curiosity as regards the comic he's about to read.

On Mon, May 27, 2024, 7:30 PM Vanderson Oliveira < @.***> wrote:

I misunderstood the issue you reported via email, I didn't realize you were talking about the names of the artists/staff in the books, I thought it was about the main list of all the authors. I've fixed that, and now all authors are shown. (check the screenshots below, is that what you're talking about?)

As for showing more details, it's simple in the coding, but the UI part... there's not enough room. A simple example is the synopsis, on a regular smartphone (1080p screen, system set to small font size), only two lines of the synopsis would be visible in a comic with a two-line title. Using the system set to a large font size, there is no room at all. And I'm not going to increase the size of the items, it's already too big...

Examples:

-

Small font size Screenshot_2024-05-27-13-53-26-917_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/94951407-085e-47ab-850d-1cc301a8b0fc

Big font size Screenshot_2024-05-27-14-17-36-577_br.com.kurotoshiro.kuro_reader_pro.open.jpg (view on web) https://github.com/VandersonQk/KuroReaderReleases/assets/7416219/58f063e7-e7f3-4312-b161-77708e21ecc7

— Reply to this email directly, view it on GitHub https://github.com/VandersonQk/KuroReaderReleases/issues/14#issuecomment-2133917372, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA522JY4D7U73ZAHEWUWOPTZEN3STAVCNFSM6AAAAABIJBEHNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHEYTOMZXGI . You are receiving this because you authored the thread.Message ID: @.***>

VandersonQk commented 1 month ago

The second doesn't after I scroll down bit and then back up.

I can't see the screenshots because you replied by email, but I know the problem. I found and fixed it when I was working on the code to merge all the author names.

PhilipElom commented 1 month ago

But why aren't the changes reflecting on my device? Do I need re-install the app?

On Mon, May 27, 2024, 8:45 PM Vanderson Oliveira @.***> wrote:

The second doesn't after I scroll down bit and then back up.

I can't see the screenshots because you replied by email, but I know the problem. I found and fixed it when I was working on the code to merge all the author names.

— Reply to this email directly, view it on GitHub https://github.com/VandersonQk/KuroReaderReleases/issues/14#issuecomment-2133982303, or unsubscribe https://github.com/notifications/unsubscribe-auth/BA522J55C4VG57DGJSJZF23ZEOEOXAVCNFSM6AAAAABIJBEHNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTHE4DEMZQGM . You are receiving this because you authored the thread.Message ID: @.***>

VandersonQk commented 1 month ago

But why aren't the changes reflecting on my device? Do I need re-install the app?

The fix will be in the next app update, but no date has been set yet.