search

VandeurenGlenn / blue_server

https://vandeurenglenn.github.io/blue_server/
MIT License
0 stars 0 forks source link

remove envs dependency from server index #11

Closed vdegenne closed 1 year ago

vdegenne commented 1 year ago

The reason for that is the env vars should probably be in api package because that's where the keys belong to.

VandeurenGlenn commented 1 year ago

The reason for that is the env vars should probably be in api package because that's where the keys belong to.

Yes, was going to say the same, I'm not comfortable it being in server exports 📦

vdegenne commented 1 year ago

@VandeurenGlenn Or even better, maybe we should put the .env file at the root of the project. so for example server can use the port, and api the keys, etc.

vdegenne commented 1 year ago

If we do that we should probably make a env package too :eyes:

vdegenne commented 1 year ago

@VandeurenGlenn check that https://github.com/VandeurenGlenn/blue_server/pull/12

vdegenne commented 1 year ago

Let's just close this branch, it's f*cked.

Accept this one https://github.com/VandeurenGlenn/blue_server/pull/12 it isolates env to its own package so we can start relying on it.