Vandivier / not-johns-linktree

an open source social home, link list, and portfolio site
https://vandivier.github.io/not-johns-linktree/
MIT License
6 stars 1 forks source link

To fix favicon and profile not loading change it to /profile.jpeg #5

Closed alicicek closed 1 year ago

alicicek commented 1 year ago

The profile and favicon weren't loading for me but I fixed it by changing the <link rel="icon" href="/not-johns-linktree/favicon.png" /> <Profile path="/not-johns-linktree/profile.jpeg" />

to

<link rel="icon" href="favicon.png" /> <Profile path="/profile.jpeg" />

Vandivier commented 1 year ago

i think this is a behavior on the dev server right? the deployed site works, so i'm not sure it's high priority

there should be some way to fix it so we see it in both places though. a build config option or using env vars are two approaches. not crazy about using env vars bc it means we are kind of developing code and seeing it locally in a way that it won't be built in prod

alicicek commented 1 year ago

im new to coding so not sure what those mean but It took me time to get it working on my local host


From: John Vandivier @.> Sent: Saturday, August 19, 2023 6:54 PM To: Vandivier/not-johns-linktree @.> Cc: Ali Cicek @.>; Author @.> Subject: Re: [Vandivier/not-johns-linktree] To fix favicon and profile not loading change it to /profile.jpeg (Issue #5)

i think this is a behavior on the dev server right? the deployed site works, so i'm not sure it's high priority

there should be some way to fix it so we see it in both places though. a build config option or using env vars are two approaches. not crazy about using env vars bc it means we are kind of developing code and seeing it locally in a way that it won't be built in prod

— Reply to this email directly, view it on GitHubhttps://github.com/Vandivier/not-johns-linktree/issues/5#issuecomment-1685074694, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJQKTF4UAX5OJMIWEATU2LTXWD4TTANCNFSM6AAAAAA3QNUSW4. You are receiving this because you authored the thread.Message ID: @.***>

Vandivier commented 1 year ago

looks like i already have an env-toggle code in the next config file:

const debug = process.env.NODE_ENV !== "production";

module.exports = {
  assetPrefix: !debug ? "/not-johns-linktree/" : "",
  // images: { loader: "imgix" },
  // reactStrictMode: true,
};
Vandivier commented 1 year ago

resolved!