search

VandyHacks / vaken

Next-gen hackathon registration system
MIT License
49 stars 12 forks source link

Replace EMAIL_REGEX with email-validator package #747

Closed siraben closed 3 years ago

siraben commented 3 years ago

Rebased on latest master.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit d44fe97c and detected 0 issues on this pull request.

View more on Code Climate.

leonm1 commented 3 years ago

Thanks for the PR!

siraben commented 3 years ago

@bencooper222 was it redundant?

siraben commented 3 years ago

Rebased on main

aadibajpai commented 3 years ago

@siraben it should be used here as well https://github.com/VandyHacks/vaken/blob/main/scripts/makeOrganizer.ts#L5 I guess

siraben commented 3 years ago

Thanks, will look into this.

aadibajpai commented 3 years ago

Thanks, will look into this.

in fact, https://github.com/VandyHacks/vaken/search?q=EMAIL_REGEX

siraben commented 3 years ago

😱 DESTROY ALL THE EMAIL REGEX