Add nvm - Githubissues

VandyHacks / vaken

Next-gen hackathon registration system

MIT License

49 stars 12 forks source link

Closed bencooper222 closed 3 years ago

bencooper222 commented 3 years ago

I think this is the right call.

Helps consistency
Makes setup easier (particularly since dev environments are going to be on two different CPU architectures soon)

bencooper222 commented 3 years ago

I did think about doing that but installing on *nix systems is involved enough (it's not a one command thing) that I don't think we can automate it.

Not to mention people who already have nvm would find the script a hassle then or the few Windows users not on WSL

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit e0a9db24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 43.0% (0.0% change).

View more on Code Climate.

bencooper222 commented 3 years ago

Oh that's just removing a dep that we removed in #762 that I accidentally added back when rebasing this PR.

bencooper222 commented 3 years ago

@leonm1 approve pls