VandyHacks / vaken

Next-gen hackathon registration system

MIT License

49 stars 12 forks source link

Add Happo/Storybook to Code coverage #781

Closed bencooper222 closed 3 years ago

bencooper222 commented 3 years ago

Summary

We lost 3% code coverage in #773 because Happo's testing didn't count as code coverage. This resolves that.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit e8e2f495 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 46.0% (3.1% change).

View more on Code Climate.

bencooper222 commented 3 years ago

Blocked by https://github.com/istanbuljs/istanbuljs/issues/572

bencooper222 commented 3 years ago

so uh there's a memory leak on this PR and the moment I add code to diagnose it... it disappears. GH gives each job 7gb of memory and the max we hit when just testing was 1.9GB.

bencooper222 commented 3 years ago

Best guess right now is it's MongoDB Memory server's fault. Guess I'll try this https://github.com/shelfio/jest-mongodb

bencooper222 commented 3 years ago

29 lines of code changed (not counting lockfile) across 18 commits - not counting rebased and ones that disappeared with force pushes