search

VandyHacks / vaken

Next-gen hackathon registration system
MIT License
49 stars 12 forks source link

Force default npm registry #812

Closed bencooper222 closed 3 years ago

bencooper222 commented 3 years ago

Summary

The package lockfile contains a reference of the URL to resolve each package too. The default registry for npm (registry.npmjs.com) is the most common but plenty of companies (like the one I work at) have their own custom registries that mirror the npm one. I must have installed a package from a corporate laptop so y'all ended up with packages.convoy.com in your lockfile... which won't resolve if you don't work at Convoy because that URL isn't open to the world.

This PR:

1) forces the use of the default npm registry in the future 2) fixes the 5 instances of packages.convoy.com appearing in the lockfile

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit bd9db6ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 41.1% (0.0% change).

View more on Code Climate.

bencooper222 commented 3 years ago

Happo stuff is the same issue that hasn't been resolved yet but we probably should