search

VandyHacks / vaken

Next-gen hackathon registration system
MIT License
49 stars 12 forks source link

Resumes #823

Closed SamLee514 closed 3 years ago

SamLee514 commented 3 years ago

Authors

@juyoungkim304 and myself

Summary

Allows sponsors and organizers to download a zip of all resumes of hackers (currently with ACCEPTED, SUBMITTED and CONFIRMED statuses) from the Manage Hackers page. Currently set up to deal with 3 tiers of sponsors, one that can access all resumes before the event, one during and one after.

Afaik, there is no "download all files in a bucket" capability in the GCS Node.js API, so the flow goes

  1. Check if the resume zip file exists in the GCP bucket (name is defined in strings.json)
  2. If it exists, then get the download link.
  3. If not, first get all the files, rename them to their respective hacker name in DB, put them in a zip, and upload that back to GCP. Then return the download link.

Additionally, if at any point a resume is uploaded to the bucket, then the zip file is deleted.

Also, the populateDb script now also has the option to fill the GCP bucket with resumes. The number of hackers is now 200 because GCP starts throwing errors if too many files are uploaded at once without some additional configuration.

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 4a841b06 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Bug Risk 1

The test coverage on the diff in this pull request is 48.4% (0% is the threshold).

This pull request will bring the total coverage in the repository to 63.2% (-0.1% change).

View more on Code Climate.

leonm1 commented 3 years ago

But dat merge commit doh