search

VandyHacks / vaken

Next-gen hackathon registration system
MIT License
49 stars 12 forks source link

Use autocomplete for state field #838

Closed Ace314159 closed 3 years ago

Ace314159 commented 3 years ago

Summary

This makes the state field in the shipping section an autocomplete, so the user is more likely to use the abbreviations rather than spelling out the full state.

Slack Thread: https://vandyhacks.slack.com/archives/C9DF81DEG/p1631488518025700

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit d9204b98 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 63.2% (0.0% change).

View more on Code Climate.

aadibajpai commented 3 years ago

I think it's more natural for people to start typing the full state name, and that is the default behaviour on most forms. So I think we should have full state names in the autocomplete. For the shipping labels thing, we can in the worst case write a simple script that maps state names to abbreviations or as Ben said the shipping company handles it for us.