VandyHacks / vaken

Next-gen hackathon registration system

MIT License

49 stars 12 forks source link

Add spacing between confirm and decline buttons #860

Closed Ace314159 closed 2 years ago

Ace314159 commented 2 years ago

Summary

This adds spacing between the confirm and decline buttons after a hacker has been accepted (N-56)

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 2bebc831 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 62.2% (0.0% change).

View more on Code Climate.

aadibajpai commented 2 years ago

@Ace314159 the space looks awesome, if you look at the happo diffs tho in some of them the button seems to go beyond the outer pink container tho. Try viewing the diffs in the diff option to see the difference.

aadibajpai commented 2 years ago

it appears there's even more diffs now

Ace314159 commented 2 years ago

The diffs seem to be a font issue. Any idea why this might occur? I didn't do anything with fonts and only modified the HackerDash component.

nkalupahana commented 2 years ago

Happo is good now :)