VandyVRC / srophe-eXist-app

eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
0 stars 1 forks source link

sources section for forms--reveal cited range in source display #178

Open millertg opened 3 years ago

millertg commented 3 years ago

@wsalesky I think we could begin the addition of each term by adding the sources in the "Sources" section, then selecting them for each term line and note/gloss line.

But, when I add the cited range (pp or juan/chapter) for a source, it isn't visible when I then go to choose the source for an entry. Thus, if I want to cite different chapters from the same book, I would not be able to select those chapters for an individual citation.

I think this would be solved if the cited range were revealed after the source had been selected in two places

On the Source page here: Screen Shot 2021-03-16 at 2 03 07 PM

And after on the Terms page here:

Screen Shot 2021-03-16 at 2 08 52 PM

wsalesky commented 3 years ago

@millertg How does it look now?

millertg commented 3 years ago

great to be able to see the cited range! Two things:

  1. when citing different ranges in the same source for a single entry, the program remembers the first one as well. Here I selected the same source twice, but with different chapters. Screen Shot 2021-03-23 at 12 04 44 PM

When I went to select the source from the Note entry page, the second time I entered the cited range seems to have remembered the first cited range: Screen Shot 2021-03-23 at 12 05 00 PM

  1. can we have "controlled" cited range units for cited ranges? e.g. pp., p., juan, chapter? (juan is a type of chapter in a traditional Chinese text)
  2. if so, it would be good to show the units, as well as just the cited range
wsalesky commented 3 years ago

Ops, I will take a look. Also, I will add the controlled units for cited range, and add them to the display.

wsalesky commented 3 years ago

@millertg How does it look now?

millertg commented 3 years ago

Something is strange with the the display of the source in terms, at least after you add one source: Screen Shot 2021-03-23 at 1 40 39 PM The units box isn't displaying possibilities Screen Shot 2021-03-23 at 1 37 49 PM Units are there once the source is added, but they are displaying after the number rather than before. I also realized when doing this that if I am adding a chapter, I would likely want to add a page number, also. Can we have both as an option? This is particularly helpful with traditional sources that are not continuously paginated. Screen Shot 2021-03-23 at 1 43 30 PM

wsalesky commented 3 years ago

@millertg How does it look now?

millertg commented 3 years ago

@wsalesky It is getting much better! But, I did see a glitch with the latest test--the Chinese characters in the title statement (line 6) didn't match what I entered, even though the pinyin did (see attached). Maybe the form remembers something from a previous use? The legacy characters are from the k000001 (https://architecturasinica.org/keyword/k000001), if that might help explain things. Screen Shot 2021-03-27 at 1 54 25 PM

wsalesky commented 3 years ago

@millertg Finally getting back to this, can you send me the generated XML that is pictured above? You can send via email. It will help me debug what is going on here.

Thanks!

millertg commented 3 years ago

Hi Winona- It is attached.

Also, I imagine that we will need to do some hand editing of these xml files before submitting them. In that case, it would work much better if the TEI generated by the form matched the records already in the system.

Here is a URI of the term in this particular test, using the actual sources we will be using for the gloss. https://architecturasinica.org/keyword/k000172 Ideally the TEI for the form-generated document would look like precisely the same, line-for line (or as close as we can get).

Is that possible?

Thanks! Tracy

-- Tracy Miller Associate Professor Department of History of Art and Architecture Department of Asian Studies Vanderbilt University

From: Winona Salesky @.> Date: Thursday, April 1, 2021 at 8:53 AM To: VandyVRC/srophe-eXist-app @.> Cc: Miller, Tracy G tracy.g.miller@Vanderbilt.Edu, Mention @.***> Subject: Re: [VandyVRC/srophe-eXist-app] sources section for forms--reveal cited range in source display (#178)

@millertghttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmillertg&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7Cbdef0d16beed4fa28c7508d8f5159050%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637528820249984390%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tiEVUqAr%2F48cjBr8%2FWRiLR0SvdsRtQW4TGzkm7O3PzE%3D&reserved=0 Finally getting back to this, can you send me the generated XML that is pictured above? You can send via email. It will help me debug what is going on here.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FVandyVRC%2Fsrophe-eXist-app%2Fissues%2F178%23issuecomment-811924427&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7Cbdef0d16beed4fa28c7508d8f5159050%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637528820249994372%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ME3PUMqDh%2BRt%2BOas%2BEWmoZxP6kelneiVLO7rv20yxjo%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGAQVC3DCFTRD2AJUKLGXY3TGR3GPANCNFSM4ZJFGH2A&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7Cbdef0d16beed4fa28c7508d8f5159050%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637528820249994372%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BXdL5QIhtdf0rb1HuFxQSpTsgT7vM1ufLAxfe08fM5o%3D&reserved=0.

wsalesky commented 3 years ago

Okay, I think I have fixed the title info. I will get back to you on the other part of the issue.