VandyVRC / srophe-eXist-app

eXist code for Syriaca.org: The Syriac Reference Portal
GNU General Public License v3.0
0 stars 3 forks source link

doubling in architectural terminology display #202

Closed millertg closed 3 years ago

millertg commented 3 years ago

@wsalesky @shubenda Can we make it so that terms marked as "alternate" are not displayed in the terminology list? Currently, terminology display pulls, I think, from zh-pinyin. when we have alternates, it will combine them. It has done this with two: https://architecturasinica.org/keyword/k000024 and https://architecturasinica.org/keyword/k000023

Screen Shot 2021-05-31 at 3 30 40 PM

Screen Shot 2021-05-31 at 3 31 09 PM

wsalesky commented 3 years ago

@millertg what is that first screen shot from? A search? If you could past in a link that would be great. thanks

millertg commented 3 years ago

@wsalesky It was from a search: https://architecturasinica.org/terminology.html?q=touxinzao&term=

wsalesky commented 3 years ago

@millertg I think this issue has been resolved. If not please re-open and let me know what I missed. Thanks!

millertg commented 3 years ago

The alternates have been removed from the index (which is great), but we can no longer see them in the display. Screen Shot 2021-06-02 at 1 19 12 PM

wsalesky commented 3 years ago

@millertg Sorry! I misread the issue and thought that was what you wanted. i will put them back in the display.

millertg commented 3 years ago

That’s ok! They were just showing together with the other version, so before as search for jixinzao resulte in: jixinzaojixin

Rather than jixinzao jixin

Do we need to have a separate record for an alternate rendering of a “concept”/ term? We had done that, and wanted to simplify since the two different terms are the same concept. But the Getty has two records and cross-references them. Perhaps that is the best solution for us as well?

Still, we will need to be able to have the code look for zh-pinyin for the search result display, and not zh-pinyin type=alternate.

Does that make any sense?

Thanks- Tracy

-- Tracy Miller Associate Professor Department of History of Art and Architecture Department of Asian Studies Vanderbilt University

From: Winona Salesky @.> Date: Wednesday, June 2, 2021 at 1:45 PM To: VandyVRC/srophe-eXist-app @.> Cc: Miller, Tracy G tracy.g.miller@Vanderbilt.Edu, Mention @.***> Subject: Re: [VandyVRC/srophe-eXist-app] doubling in architectural terminology display (#202)

@millertghttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmillertg&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7C0721e874a56d43ebd83208d925f692be%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637582563218287761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=JzCctTFoe9Ud2v0rAO7ZTXjNnFU4wgaNXxgAthe7%2FTI%3D&reserved=0 Sorry! I misread the issue and thought that was what you wanted. i will put them back in the display.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FVandyVRC%2Fsrophe-eXist-app%2Fissues%2F202%23issuecomment-853293949&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7C0721e874a56d43ebd83208d925f692be%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637582563218287761%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VyqUMtzAw4KJSvZ2hJY5g3nw0mhqweBCjfiaLUak2IM%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGAQVC26HQGK6K34LWNHAWLTQZ337ANCNFSM453N6XCA&data=04%7C01%7Ctracy.g.miller%40vanderbilt.edu%7C0721e874a56d43ebd83208d925f692be%7Cba5a7f39e3be4ab3b45067fa80faecad%7C0%7C0%7C637582563218297754%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gWenSES4gGjYT2DhFBcq4vI1rnKnmnNjLN3rl0vegkE%3D&reserved=0.