search

Vanethos / flutter_notification_permissions

Plugin for Flutter to check and ask for Notification Permissions
BSD 2-Clause "Simplified" License
81 stars 75 forks source link

Null Safety Migration #34

Closed Aulig closed 3 years ago

Aulig commented 3 years ago

Hey, just wanted to check in if you're already working on migrating to null safety. Or are you waiting on a dependency to migrate?

anoop4real commented 3 years ago

In my app, this is the only package which is not null safe, any plans on migration soon?

Aulig commented 3 years ago

Thanks for your PR @anoop4real Would be awesome if you could check https://github.com/Vanethos/flutter_notification_permissions/pull/36 out @Vanethos Thank you!

anoop4real commented 3 years ago

@Aulig For the time being may be you can use my fork, add below in pubspec.yaml (correct the indentation when you add to yaml), then it will use my fork, may be you can also test my changes and as a note once the PR is approved make sure you put back the original as I might not be maintaining this further.

notification_permissions: git: url: https://github.com/anoop4real/flutter_notification_permissions

Aulig commented 3 years ago

Thanks again @anoop4real! I've tested it, everything seems to be working in my app on Android and iOS.

anoop4real commented 3 years ago

Great hope the PR gets approved soon

Vanethos commented 3 years ago

Approved, in a couple of hours I'll get the new version up, thanks you @Aulig and @anoop4real !

Aulig commented 3 years ago

Awesome, thank you!

ghost commented 3 years ago

Will it be also deployed to pub.dev?

anoop4real commented 3 years ago

@Vanethos Thanks a lot for approving. Forgot to mention, I was getting deprecation warning from one of the .java file (I think it was for Android), it is worth looking into that also if you have time

Vanethos commented 3 years ago

@anoop4real at the end of this month I'll carve some time for that if I can :D