search

Vanilla-Expanded / VanillaExpandedFramework

Vanilla Expanded Framework for RimWorld
Other
73 stars 37 forks source link

Vanilla Expanded Abilities delete the pawn if removed. #24

Open ottersholdhands opened 1 year ago

ottersholdhands commented 1 year ago

Tested on Cathorse from Vanilla Genetics Expanded. If you have a Cathorse in a game and you remove the Pounce ability code then it will give a few errors and delete the pawn from the game after you load the game back up.

https://gist.github.com/HugsLibRecordKeeper/519003021f790587dc7d320a01d0f983

juanosarg commented 1 year ago

Errrr... so?

Owlchemist commented 1 year ago

Tested on Cathorse from Vanilla Genetics Expanded. If you have a Cathorse in a game and you remove the Pounce ability code then it will give a few errors and delete the pawn from the game after you load the game back up.

https://gist.github.com/HugsLibRecordKeeper/519003021f790587dc7d320a01d0f983

fwiw I can confirm this and ran into a similar issue. For instance removing a VPE psycast will cause the pawn's scribe to fail and they'll just poof. I had suggested a sanity check on the ability expose to fix this but I think that got filed into the "won't fix" category. Well perhaps "fix" isn't the right word. It'd be more like an enhancement request to make the code a more durable towards these sorta shenanigans.

legodude17 commented 1 year ago

The issue is that making the change would imply it is supported to remove or change abilities in a save, which it is not. The more weird edge cases we support, the more work it is to maintain the framework.