search

Vanilla-Expanded / VanillaExpandedFramework

Vanilla Expanded Framework for RimWorld
Other
69 stars 34 forks source link

[Feature Request] [PipeNet] Float the pipe converters #58

Open MrHydralisk opened 1 year ago

MrHydralisk commented 1 year ago

Since most of the pipe storage use float values already, then maybe some other values that currently still limited by int should become float too.

Currently talking about ratio from CompProperties_ConvertThingToResource и CompProperties_ConvertResourceToThing, that limited by int to only decrease consumtion by x1, x2, x3.... Swapping to float will allow also increase in consumption and more precise control over it. Would also require removing some convertion to int in PipeNet methods DistributeAmongConverters() and GetFromConverters() for float ratio to work.

Asking cause I need to adjust ratio of two converters to thing to use 2/3 and 2 of storage resource to make one mod compatible with pipe system. I could try patching it on my side, which prob wouldn't be as optimal as adjusting framework straight away.

MrHydralisk commented 1 year ago

Actually now when I tested a bit more I getting a feeling that ratio due to some int logic might not work at all. Cause it will return "[PipeSystem] Converted 0 resource for 2".

It seems like PipeNet Git ver here was changed here on Jul 6. And you prob already solve it. But Steam ver seems to still have the old code. So maybe it already fixed here and just not published. Sorry to bother if that's the case.