Vanilla Expanded Core breaks the Anomaly Abductor Obelisk

dbartussek commented 5 months ago

I've used a mod setup with only Harmony, Core, Anomaly and Vanilla Expanded Framework to isolate this issue.

To reproduce:

Start a new game (normal start and dev quicktest both work)
Use the following dev tools action: Spawn thing => WarpedObelisk_Abductor
With god mode, use the DEV: Trigger interaction effect action on the obelisk
Wait for the "disappearing" interaction to finish. The game will now softlock in the labyrinth generation screen.

I have attached the resulting log file. The root issue starts on line 91, seemingly every frame afterwards a different method fails as a result and fills up the log. Player.log

Relevant excerpt (lines 91-104):

Exception from asynchronous event: System.NullReferenceException: Object reference not set to an instance of an object
[Ref 2278AB00]
 at VFECore.World_NaturalRockTypesIn_Patch.Postfix (System.Collections.Generic.IEnumerable`1[T] rocks, System.Int32 tile, RimWorld.Planet.World __instance) [0x0000d] in <36b63cb2205644728220a5610cdd41de>:0 
 at RimWorld.Planet.World.NaturalRockTypesIn (System.Int32 tile) [0x000d4] in <9f0455800725468190a2ddad977330df>:0 
     - POSTFIX OskarPotocki.VFECore: IEnumerable`1 VFECore.World_NaturalRockTypesIn_Patch:Postfix(IEnumerable`1 rocks, Int32 tile, World __instance)
 at Verse.RockNoises.Init (Verse.Map map) [0x00015] in <9f0455800725468190a2ddad977330df>:0 
 at Verse.MapGenerator.GenerateContentsIntoMap (System.Collections.Generic.IEnumerable`1[T] genStepDefs, Verse.Map map, System.Int32 seed) [0x00041] in <9f0455800725468190a2ddad977330df>:0 
     - PREFIX OskarPotocki.VFECore: Void VFECore.MapGenerator_GenerateContentsIntoMap_Patch:Prefix(IEnumerable`1& genStepDefs, Map map, Int32 seed)
 at Verse.MapGenerator.GenerateMap (Verse.IntVec3 mapSize, RimWorld.Planet.MapParent parent, Verse.MapGeneratorDef mapGenerator, System.Collections.Generic.IEnumerable`1[T] extraGenStepDefs, System.Action`1[T] extraInitBeforeContentGen, System.Boolean isPocketMap) [0x00277] in <9f0455800725468190a2ddad977330df>:0 
     - POSTFIX OskarPotocki.VFECore: Void VFECore.MapGenerator_GenerateMap_Patch:Postfix(Map __result)
 at Verse.PocketMapUtility.GeneratePocketMap (Verse.IntVec3 size, Verse.MapGeneratorDef generatorDef, System.Collections.Generic.IEnumerable`1[T] extraGenStepDefs, Verse.Map sourceMap) [0x00017] in <9f0455800725468190a2ddad977330df>:0 
 at RimWorld.CompObelisk_Abductor+<>c__DisplayClass30_0.<GenerateLabyrinth>b__0 () [0x00026] in <9f0455800725468190a2ddad977330df>:0 
 at Verse.LongEventHandler.RunEventFromAnotherThread (System.Action action) [0x00008] in <9f0455800725468190a2ddad977330df>:0  
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

dbartussek commented 5 months ago

Ok, so while trying to find a solution I've just found out that this issue has already been fixed in https://github.com/Vanilla-Expanded/VanillaExpandedFramework/commit/81867b36f6682d8cdb470f8d2144d0c755ec67f8. I hope this gets published to the workshop soon!

Taranchuk commented 5 months ago

Steam version was updated yesterday. You have an outdated version. Force verify game files to trigger all mod updates.

Vanilla-Expanded / VanillaExpandedFramework

Vanilla Expanded Core breaks the Anomaly Abductor Obelisk #91