search

Vanilla-Expanded / VanillaNutrientPasteExpanded

1 stars 4 forks source link

support hoppers with more than one stack #1

Open zed-0xff opened 1 year ago

zed-0xff commented 1 year ago

i.e. "Fridges Are Hoppers" mod

till-eulenspiegel commented 11 months ago

@zed-0xff Actually ended up here because of seeing your Mod off-of FridgesAreHoppers. Was actually coming to open an issue for this and do Similarly. but It'd be nice to get your PR landed.

This is just 1 of 2 changes you added to VNPE, this is missing the: foreach(IntVec3c in cahcedHopers[index].OccupiedRect()). And the OccupiedRect change also needs to be in FindFeedInAnyHopper right?

(Also what's your discord Username so we can potentially merge your change into FridgesAreHoppers if they don't merge your pr. If you are open to it I can give credit as well)

@KylianB Not sure if you saw this PR?

KylianB commented 11 months ago

I indeed didn't see it, thank you for the tag. I will check this out.

zed-0xff commented 11 months ago

This is just 1 of 2 changes you added to VNPE, this is missing the: foreach(IntVec3c in cahcedHopers[index].OccupiedRect()). And the OccupiedRect change also needs to be in FindFeedInAnyHopper right?

This is kinda new feature of my mod, so not only adjacent cells of multi-cell hoppers/fridges will be processed, but all of them. Maybe quesionable or a bit OP, so this PR will only add processing of adjacent cells.

till-eulenspiegel commented 11 months ago

This is just 1 of 2 changes you added to VNPE, this is missing the: foreach(IntVec3c in cahcedHopers[index].OccupiedRect()). And the OccupiedRect change also needs to be in FindFeedInAnyHopper right?

This is kinda new feature of my mod, so not only adjacent cells of multi-cell hoppers/fridges will be processed, but all of them. Maybe quesionable or a bit OP, so this PR will only add processing of adjacent cells.

It's really a bugfix. If you put a nxn hopper next to something , the expected behavior is every slot and every stack per slot would be available since it's in the hopper. When code doesn't match expected behavior it's a bug.