search

Vanilla-OS / ABRoot

ABRoot is a utility that provides full immutability and atomicity to a Linux system, by transacting between two root filesystems. Updates are performed using OCI images, to ensure that the system is always in a consistent state.
http://abroot.vanillaos.org/
GNU General Public License v3.0
309 stars 24 forks source link

config-editor doesn't detect broken config #333

Open taukakao opened 2 months ago

taukakao commented 2 months ago

If you create an invalid config, abroot config-editor will save it anyway and will not be able to run again to fix the issue.

mirkobrombin commented 2 months ago

A built-in editor is probably the best solution here, so we validate it before saving.

taukakao commented 2 months ago

@mirkobrombin I think a built-in editor would be overkill. We could alternatively copy the file somewhere in /tmp, edit it there and validate it before writing it back to /etc/abroot

mirkobrombin commented 2 months ago

I would define it as "overkill" but complex. Anyway your idea is better.