Vanilla-OS / chronos-frontend

A frontend in Vue.js for the Chronos documentation server.
https://docs.vanillaos.org
GNU Affero General Public License v3.0
6 stars 4 forks source link

Bug: fix support for auto dark/light mode switching #84

Closed kbdharun closed 1 month ago

mirkobrombin commented 2 months ago

Pinging @GabsEdits since he made some changes recently

GabsEdits commented 2 months ago

Wasn't this fixed in https://github.com/Vanilla-OS/chronos-frontend/commit/a7546b2e81ec30f1975c9f349e1be6dc72d8b26b ? It seems fine for me.

Update: I just checked, you need clear the cache. Once you do that everything should work well, as it did for me.

kbdharun commented 2 months ago

Update: I just checked, you need clear the cache. Once you do that everything should work well, as it did for me

Yep, can confirm the same, would it be possible to seamlessly achieve the same without requiring clearing of cache or force reloading the page?

GabsEdits commented 2 months ago

Update: I just checked, you need clear the cache. Once you do that everything should work well, as it did for me

Yep, can confirm the same, would it be possible to seamlessly achieve the same without requiring clearing of cache or force reloading the page?

The requirement of clearing of cache is here just because this was a recent change. I believe it's possible to make new option that follows always the system setting, something like what Docus does. I can investigate it if you want.

kbdharun commented 2 months ago

The requirement of clearing of cache is here just because this was a recent change. I believe it's possible to make new option that follows always the system setting, something like what Docus does. I can investigate it if you want.

Sure, feel free to investigate it and let me know if you find something.