search

Vanilla-OS / desktop-image

Containerfile for the Vanilla OS Desktop image.
https://images.vanillaos.org/#/recipe/desktop
GNU General Public License v3.0
31 stars 20 forks source link

Added support for opening terminal in nautilus #201

Closed fluoriteByte closed 1 month ago

fluoriteByte commented 1 month ago

using https://github.com/Stunkymonkey/nautilus-open-any-terminal as the script, tag 0.6.0

fluoriteByte commented 1 month ago

from what i gleam from the logs, it seems to have skipped for some reason the module file i put there

axtloss commented 1 month ago

You still have to tell it to include the module in the recipe.yml file

fluoriteByte commented 1 month ago

oop lol

fluoriteByte commented 1 month ago

Do i have to explicitly add make as an apt dep for this module? I guessed it might be available because of earlier modules that had it

axtloss commented 1 month ago

technically it's not required, but it'd be better to have it in case earlier modules suddenly dont need it anymore

fluoriteByte commented 1 month ago

Do you know why it failed? Cus im pretty sure make only gets cleaned at the end

axtloss commented 1 month ago

https://github.com/Vanilla-OS/desktop-image/actions/runs/10327285133/job/28592228057?pr=201#step:12:8668 it cant find localization files, you have to run make build install schema

axtloss commented 1 month ago

Also change the commit title to feat: add support for opening terminal in nautilus (see the contributor guidelines for further reference)

axtloss commented 1 month ago

Thanks for the contribution!