Vanilla-OS / desktop-image

Containerfile for the Vanilla OS Desktop image.
https://images.vanillaos.org/#/recipe/desktop
GNU General Public License v3.0
31 stars 20 forks source link

fix:[close #183] Restrict differ to dev branch only #207

Open jardon opened 3 weeks ago

jardon commented 3 weeks ago

Tested here on commit 0e4c7ce

closes #183

jardon commented 3 weeks ago

That is likely correct. The release is tagged as dev, but we can wait to confirm.

jardon commented 3 weeks ago

I impatiently updated the PR. It now targets dev and no longer hard codes the tag

kbdharun commented 3 weeks ago

I impatiently updated the PR. It now targets dev and no longer hard codes the tag

Nice, however, the issue with the current implementation is stable users use the main tag which is pushed on a tag by this job:

https://github.com/Vanilla-OS/desktop-image/blob/1cfa836528e67b47848464027610a88f6b968e99/.github/workflows/vib-build.yml#L84-L87

So if differ is run and generates a changelog for specific tags, the end users might not get the changelog since it would be uploaded to the differ instance for the tag instead of the main one.

jardon commented 3 weeks ago

i think im missing some info, but if i understand correctly:

does that track?

Edit: oh I see my branch is behind