TypeError raised by Done button

[Mizumo-prjkt]

This has been going on for hours earlier and decided to give up

I am trying to install Neko, a Tachiyomi fork for browsing manga with Mangadex as a service

I used a universal version of the APK since my unit is actually x86_64

I noticed that Sideload didnt do anything to install this apk so i decided to retry and retry, wait for an hour and aborted, and made this report

And here is also my suggestion since i found the issue:

Waydroid wasn't installed and i didnt know.

So i used vsx and it is installing the waydroid image, will take a while since sourceforge is slow.

My recommendation

Maybe let sideload check if Waydroid is present in the machine because the user may think that Sideloading APK may be a lie

I'll also submit my findings on r/VanillaOS on Reddit later as im on a quest to bug hunting

Have a good day!

[mirkobrombin]

Waydroid initialization were introduced here https://github.com/Vanilla-OS/sideload-utility/commit/3db0891a1afab3db5128b8a42098a62060049033

There is chance you were hitting this bug https://github.com/Vanilla-OS/sideload-utility/commit/ba6d6726908baeba4e4bcfd69aa2dbe6587b76a2

We are building and releasing an update to ensure the sideload app gets updated.

[Mizumo-prjkt]

Thank you.

Also, how to get logs on a particular situation so I can maybe copy-paste it? So to ease the debug on your side?

[mirkobrombin]

Thank you.

Also, how to get logs on a particular situation so I can maybe copy-paste it? So to ease the debug on your side?

Running it via CLI:

vanilla-sideload --install <path_to_deb_or_apk>

[Mizumo-prjkt]

scara@apx-vso-pico:~/Downloads$ vanilla-sideload --install neko-universal.apk
Sideload 0.1.0
TypeError: Must be number, not NoneType
Traceback (most recent call last):
  File "/usr/share/vanilla-sideload/vanilla_sideload/views/install.py", line 154, in __on_install_clicked
    self.__pkg.install_cmd_as_list,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/types.py", line 122, in install_cmd_as_list
    return shlex.split(self.install_cmd)
                       ^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/types.py", line 118, in install_cmd
    return SideloadUtils.get_vso_cmd(f"android install --local {self.path}")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/utils.py", line 35, in get_vso_cmd
    if os.path.exists(f"{os.environ['VSO_PATH']}/vso"):
                         ~~~~~~~~~~^^^^^^^^^^^^
  File "<frozen os>", line 679, in __getitem__
KeyError: 'VSO_PATH'

and then its stuck, and didn't do anything

as for waydroid status:

scara@apx-vso-pico:~$ vso android status
INITIALIZED
scara@apx-vso-pico:~$ 

but sadly i cant check whether waydroid is really running as im isolated within the core system

[Mizumo-prjkt]

Even declaring full path, not working

scara@apx-vso-pico:~/Downloads$ vanilla-sideload --install /home/scara/Downloads/neko-universal.apk
Sideload 0.1.0
TypeError: Must be number, not NoneType
Traceback (most recent call last):
  File "/usr/share/vanilla-sideload/vanilla_sideload/views/install.py", line 154, in __on_install_clicked
    self.__pkg.install_cmd_as_list,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/types.py", line 122, in install_cmd_as_list
    return shlex.split(self.install_cmd)
                       ^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/types.py", line 118, in install_cmd
    return SideloadUtils.get_vso_cmd(f"android install --local {self.path}")
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/vanilla-sideload/vanilla_sideload/backend/utils.py", line 35, in get_vso_cmd
    if os.path.exists(f"{os.environ['VSO_PATH']}/vso"):
                         ~~~~~~~~~~^^^^^^^^^^^^
  File "<frozen os>", line 679, in __getitem__
KeyError: 'VSO_PATH'

[mirkobrombin]

Have you updated your system to receive the fix? That exact bug was fixed several hours ago

[Mizumo-prjkt]

ok i missed that

anyways, updated the system and

horray

but pressing "Done" says this