Vanilla-OS / vanilla-installer

A frontend in GTK 4 and Libadwaita for Albius.
GNU General Public License v3.0
79 stars 31 forks source link

feat[#352]: Support specifying custom images #396

Closed muhdsalm closed 2 months ago

muhdsalm commented 2 months ago

Closes #352

Not tested in a VM, but the finals and ABRoot dump seem to line up properly.

taukakao commented 2 months ago

Please add screenshots of the changed GUI here.

muhdsalm commented 2 months ago

Screenshot from 2024-07-26 21-06-33

Icons are broken on my system :frowning_face:

taukakao commented 2 months ago

Maybe you're missing the gnome-icon-theme package or something.

But anyway, I think the warning could be more descriptive. Something like: "The author of the image has complete control over your system. Only install images of people you trust."

Also, "if you don't know what you're doing" sounds a bit rude. Maybe "Only enable this if you trust the author of the image"

muhdsalm commented 2 months ago

In its current form, it would've been seen by everybody, hence I wanted to make sure no one would touch it unless they knew what they were doing.

But now that we've decided to move it into its own section, it does make sense to make the warning more descriptive than "don't touch!"

muhdsalm commented 2 months ago

Video of the new format:

https://github.com/user-attachments/assets/9124b3ee-d44b-416e-8b34-ceba5e8b64c5

taukakao commented 2 months ago

if the custom-image toggle is off:

* just have the default image url from recipe as default input_entry

* probably not show the custom-image row in summary or point the value to default row?

@Muqtxdir I think these are addressed now.

taukakao commented 2 months ago

Also, I would recommend waiting with merging this until Monday.

It could cause issues that we can better deal with after the release.

Muqtxdir commented 2 months ago

minor nit: let's merge it after post release not immediately to avoid confusion

taukakao commented 2 months ago

@muhdsalm If you want to merge this now then I'm fine with it.