search

Vanilla-OS / vanilla-system-operator

VSO is an utility which allows you to perform maintenance tasks on your Vanilla OS installation.
GNU General Public License v3.0
31 stars 15 forks source link

remove the creation of 'vso tasks rotate' autostart file #130

Closed nellfs closed 4 months ago

nellfs commented 4 months ago

Currently vso creates a file that ran vso tasks rotate in /home/user/.config/autostart/ https://github.com/Vanilla-OS/vanilla-system-operator/blob/05757fb763d43645db2c6ce8b4796f831f928318/core/tasks.go#L271-L303

There are a few problems with this:

  1. The created file uses the old command for vso tasks rotating (so the file actually doesn't work currently). https://github.com/Vanilla-OS/desktop-image/issues/141

  2. Writing a file in the user's home directory makes it hard to update; we would need to directly modify the user's home to correct the error mentioned above.

The best thing to do in this case would be to create a systemd service to start vso tasks rotate as mentioned by @taukakao https://github.com/Vanilla-OS/desktop-image/issues/141

In fact I already have an issue and a PR open to solve this, so this issue complements it.