Vanilla-OS / vanilla-system-operator

VSO is an utility which allows you to perform maintenance tasks on your Vanilla OS installation.
GNU General Public License v3.0
31 stars 15 forks source link

vso ignores smart config #6

Closed bketelsen closed 1 year ago

bketelsen commented 1 year ago

with smart updates turned off, vso trigger-update --now still refuses to update because checks failed.

root@vanilla:/etc/vso# cat config.json 
{
  "updates": {
    "schedule": "weekly",
    "smart": false
  }
}root@vanilla:/etc/vso# acpi
Battery 0: Discharging, 0%, rate information unavailable
Battery 1: Full, 100%
root@vanilla:/etc/vso# vso trigger-update --now
Triggering update now...
Starting smart update check...
Low battery detected, skipping update.
Smart update detected device is being used, skipping update.
root@vanilla:/etc/vso# 
mirkobrombin commented 1 year ago

I wonder how this is possible

bketelsen commented 1 year ago

how can I help investigate?

mirkobrombin commented 1 year ago

I think we can only look at the code

mirkobrombin commented 1 year ago

This was really weird, the function returns a string but it is not a string. Handling it has a bool works. I cannot use the negative condition for some reasons.