Aggregate: Elementary methods

Vannevelj / VSDiagnostics

A collection of static analyzers based on Roslyn that integrate with VS

GNU General Public License v2.0

65 stars 16 forks source link

Aggregate: Elementary methods #503

Open Vannevelj opened 8 years ago

Vannevelj commented 8 years ago

[x] ElementaryMethodsOfTypeInCollectionNotOverridden #3
[x] ImplementEqualsAndHashcode #477
[x] EqualsAndGetHashcodeNotImplementedTogether #172
[x] StructWithoutElementaryMethodsOverridden #185
[x] GetHashCodeRefersToMutableField #559

Vannevelj commented 8 years ago

Right now we have two private helpers in #172 that generate the Equals(object) and GetHashcode() methods. We should probably extract this to a common file so we can re-use it for the others.

Also note: let's not use methods so we only have to construct the MethodDeclaration once.