search

Vantiv / litle-integration-magento

Magento Integration for Vantiv eCommerce
https://developer.vantiv.com/community/ecommerce
MIT License
6 stars 10 forks source link

Vault and other improvements #2

Closed johnholden closed 11 years ago

johnholden commented 12 years ago

Passing along a bunch of updates I've made. You can feel free to review and accept, otherwise it would be helpful to create a develop branch on your side for pulling changes before they go into master.

John

arch85 commented 11 years ago

Hi John,

Thank you for the pull request. We went over the code and will accept the pull request with the following changes:

1) Reverting changes in the LitleSDK folder (since this is our php SDK, and the version number needs to be consistent). 2) Drop order related info (order_number, order_id, order_type) from litle_vault table -- since only unique tokens will be stored from here on, we shouldn't be storing order related info.

If you would like to store order_type, we can store it in a separate table -- please let us know.

Thanks!

johnholden commented 11 years ago

Hey Archit,

Sorry for the long silence. We're in the midst of our launch but I will make these changes eventually and resubmit for pull. I just did a pull request for a typo I just found.

Cheers, John

On Tue, Sep 25, 2012 at 3:25 PM, arch85 notifications@github.com wrote:

Hi John,

Thank you for the pull request. We went over the code and will accept the pull request with the following changes:

1) Reverting changes in the LitleSDK folder (since this is our php SDK, and the version number needs to be consistent). 2) Drop order related info (order_number, order_id, order_type) from litle_vault table -- since only unique tokens will be stored from here on, we shouldn't be storing order related info.

If you would like to store order_type, we can store it in a separate table -- please let us know.

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/LitleCo/litle-integration-magento/pull/2#issuecomment-8866875.

arch85 commented 11 years ago

Hi John,

No worries! We have already made the relevant changes and released a new version of our integration. You can track the changes in our repository if you're interested.

Thank you again for your help!

johnholden commented 11 years ago

Ok, even better! I will definitely keep an eye on changes so we can keep the latest integrated.

Thanks, John

On Wed, Oct 17, 2012 at 12:36 PM, arch85 notifications@github.com wrote:

Hi John,

No worries! We have already made the relevant changes and released a new version of our integration. You can track the changes in our repository if you're interested.

Thank you again for your help!

  • Archit

    — Reply to this email directly or view it on GitHubhttps://github.com/LitleCo/litle-integration-magento/pull/2#issuecomment-9534167.