Vapok / CommunityDKP

Preimer DKP Management Tool for WoW Classic
https://www.curseforge.com/wow/addons/communitydkp
GNU General Public License v3.0
8 stars 19 forks source link

Adding option to auto-loot and auto-trade items to the winner of a bid. #174

Closed Chalos-Atiesh closed 3 years ago

Chalos-Atiesh commented 3 years ago

https://github.com/Vapok/CommunityDKP/issues/172

Chalos-Atiesh commented 3 years ago

core.DB.pendingLoot is only used if the bid is initiated from bags. If initiated from the loot window the item shouldn't enter that table. But I didn't think that table should be reset if the player's don't actually trade. Maybe some timeout function for some reasonable time but then that would make the entire system massively more complex.

Chalos-Atiesh commented 3 years ago

Oh, that or the table could be reset if they player toggles off the option.

Taidtuskecyh commented 3 years ago

Imo it should be reseted every time the addon loads and also when the option is ticked off.

Otherwise you might end up with some unwanted trade window behaviors

Chalos-Atiesh commented 3 years ago

That's true. Should be fixed now.